The element between the app and the views can shrink, so pages scroll on a phone - #333
Merged
Conversation
… pages scroll Measured in a headless browser at phone size rather than guessed: the main element that holds the views is a flex item whose default min-height is auto, which refuses to shrink below its content. In the phone's column that let a tall page grow the layout past the viewport, Settings measured 2102px inside an 844px app, which carried the navigation bar off-screen and left nothing able to scroll, because the scrolling containers inside each view never got a bounded height to work against. With min-height zero every view now fits the viewport and its own scroller does the work: verified across chat, settings, help, library, stats, agents, search, and query, each reporting an app that fits and a navigation bar on the bottom edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured in a headless browser at 390x844 rather than guessed at.
main.content, between.app-bodyand the views, is a flex item whose defaultmin-height: autorefuses to shrink below its content. In the phone's column layout that let a tall page grow the whole layout past the viewport: Settings measured 2102px inside an 844px app, which pushed the navigation bar off-screen (nav@2143) and left nothing able to scroll, because.help-contentand the other per-view scrollers never received a bounded height to work against. Chat looked fine only because its content already fits.main.content { min-height: 0; min-width: 0 }fixes it. Re-measured across every view, each now reporting an app that fits the viewport, the bar on the bottom edge, and a working inner scroller: