Skip to content

Superseded by #446 - #445

Closed
danielabbatt wants to merge 1 commit into
mainfrom
fix/DNAA-1317-vpn-exclusion-source
Closed

danielabbatt wants to merge 1 commit into
mainfrom
fix/DNAA-1317-vpn-exclusion-source

Conversation

@danielabbatt

@danielabbatt danielabbatt commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #446.

A VPN exclusion rule with a VLAN source is returned as "source":{"vlanId":"920","port":"any"}, which failed deserialization of the whole byNetwork response while Source was a string. Applies to custom and application rules. The field is not in the OpenAPI spec; shape taken from the live API. Roll-forward of 1.70.39.
@codacy-production

codacy-production Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity

Metric Results
Complexity 4

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab72c3f) 7884 2968 37.65%
Head commit (883f4c1) 7884 (+0) 2968 (+0) 37.65% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#445) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@danielabbatt danielabbatt changed the title DNAA-1317 Type VPN exclusion rule source as an object Superseded by #446 Oct 9, 2026
@danielabbatt
danielabbatt deleted the fix/DNAA-1317-vpn-exclusion-source branch October 9, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant