enable single node ZGC testing - #768
Open
occasional-handbook wants to merge 3 commits into
Open
occasional-handbook wants to merge 3 commits into
occasional-handbook wants to merge 3 commits into
Conversation
Generate changelog in
|
occasional-handbook
marked this pull request as draft
September 2, 2026 17:39
occasional-handbook
marked this pull request as ready for review
September 3, 2026 10:13
policy-bot
Bot
dismissed
parker89’s stale review
September 3, 2026 13:21
Invalidated by push of e6cbdcc
ash211
reviewed
Sep 3, 2026
| AllowHeapShrink bool `yaml:"allowHeapShrink,omitempty"` | ||
| // ZGCCanaryHostnameSuffix replaces the SLS Packaging GC profile options on the host whose name has the | ||
| // configured suffix. | ||
| ZGCCanaryHostnameSuffix string `yaml:"zgcCanaryHostnameSuffix,omitempty"` |
Contributor
There was a problem hiding this comment.
if we were to release this beyond RC, I think we should change this to be more broad and flexible.
For example, an option where you can more generally override config on canary node0, for some fraction of nodes. This way you can canary settings other than GC (like string interning settings -XX:+UseStringDeduplication), and also canary different fractions of nodes (instead of just one node: node0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
we cannot test ZGC on a single node, it is all-or-nothing. Instead, we could allow a single node to use ZGC, and compare performance more directly.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?