fix: Make 'sed` command cross-platform. - #439
Open
nguyenpanda wants to merge 2 commits into
Open
Conversation
…mentation differences on BSD. **Error encountered on macOS:** `sed: 1: "...": extra characters at the end of n command` **Reference:** [StackOverflow: sed command with -i option in place editing works fine on Ubuntu but not Mac](https://stackoverflow.com/questions/16745988/sed-command-with-i-option-in-place-editing-works-fine-on-ubuntu-but-not-mac) ## Description This PR fixes a cross-platform scripting issue in `bin/init`. The `-i` (in-place) flag behaves differently between GNU `sed` (Linux) and BSD `sed` (macOS). On macOS, BSD `sed` requires a space between the `-i` flag and the backup extension (or empty string), whereas GNU `sed` requires no space. The previous implementation (`sed -i''`) caused the script to fail on macOS. This update implements a cross-platform approach so the configuration files generate successfully on both Linux and macOS environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
bin/init::set_up_config_fileserror on macOS due tosedimplementation differences on BSD.Error encountered on macOS:
sed: 1: "...": extra characters at the end of n commandReference:
StackOverflow: sed command with -i option in place editing works fine on Ubuntu but not Mac
Description
This PR fixes a cross-platform scripting issue in
bin/init. The-i(in-place) flag behaves differently between GNUsed(Linux) and BSDsed(macOS).On macOS, BSD
sedrequires a space between the-iflag and the backup extension (or empty string), whereas GNUsedrequires no space. The previous implementation (sed -i'') caused the script to fail on macOS. This update implements a cross-platform approach so the configuration files generate successfully on both Linux and macOS environments.Related issues / Pull Requests
N/A
Contributor Agreement