Repository navigation
fix(client): send the feed bbox latitude first - #6
Merged
Merged
Conversation
get_feed(bbox=...) joined the box as given, (west, south, east, north), but /v1/feed reads minLat,minLng,maxLat,maxLng. The overlay then matched latitudes against the longitudes and the box selected the wrong area, usually none. The argument keeps its documented shape, (west, south, east, north); only the wire order changes to south,west,north,east, the same fix as the TypeScript SDK. A bbox that is not four values now raises ValueError instead of being forwarded as is. Adds offline tests (httpx mock transport, sync and async) for the wire order, list and integer input, `near` winning over `bbox`, and the shape check. Updates the README and the changelog. Co-authored-by: claude-code/anthropic/sonnet-5.5 <claude-code@agents.peck.to>
A module docstring, the SourceHandle docstring and the 0.3.0 changelog entry referred to files and repositories that are not part of this project. Describe the behaviour itself instead: how the Zanaadu user number is derived from the source app's registry transactions, without the external spec's section numbers. Same wording as the TypeScript SDK. No runtime change. Co-authored-by: claude-code/anthropic/sonnet-5.5 <claude-code@agents.peck.to>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_feed(bbox=...)joined the box as given,(west, south, east, north), but/v1/feedreadsminLat,minLng,maxLat,maxLng. The overlay matched latitudes against the longitudes, so the box selected the wrong area (usually none). Same bug and fix as the TypeScript SDK (overlay-social/sdk#14).(west, south, east, north); it is now sent assouth,west,north,east.bboxthat is not four values raisesValueErrorbefore any request, instead of being forwarded as is.nearstill wins overbbox; its wire format is unchanged.tests/test_feed_query.py(httpx mock transport, sync and async): wire order, list and integer input,nearoverbbox, nobboxwithout a geo filter, wrong-shape rejection. Six of them fail without the fix.A second commit replaces pointers to non-public files in a docstring and the 0.3.0 changelog entry with a description of the behaviour (no runtime change).
Callers
Anyone who worked around the bug by passing latitude first should switch to the documented order.
Verification
pip install -e .[test] && pytest -qon Python 3.14: 14 passed (6 live tests against the overlay, 8 new offline tests). CI runs the samepytest -qon Python 3.10 and 3.12.🤖 Generated with Claude Code