Fix org role permission string, remove the now-unneeded diagnostic - #178
Merged
Conversation
The live organization-fine-grained-permissions API rejected manage_organization_runners (422); a one-time diagnostic dispatch (github-config#175, #177) confirmed the real identifier is write_organization_runners_and_runner_groups ("Manage organization runners and runner groups"). Fix the role's permissions list, and remove the diagnostic step and its input entirely -- it was genuinely one-time (unlike exclude_addresses/state_rm_addresses/import_address, which are reusable escape hatches), so apply.yaml is restored to its pre-#175 shape. NO-ISSUE
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe workflow removes the fine-grained permission listing input and related API lookup. Import, state removal, and apply steps use their normal execution conditions. The runner manager role now uses ChangesApply workflow and runner permissions
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the root cause of #174/#176:
manage_organization_runners(from #173) was rejected by the live API with422 Invalid permission. A one-time diagnostic dispatch of #175/#177 confirmed the real identifier directly fromGET /orgs/osac-project/organization-fine-grained-permissions(run 31149779707):Updates
organization.tf'spermissionslist accordingly.Also removes the diagnostic step and its
list_org_fine_grained_permissionsinput fromapply.yamlentirely -- it did its one job. Unlikeexclude_addresses/state_rm_addresses/import_address, which are reusable escape hatches worth keeping, this had no future utility once the string was known.apply.yamlis now byte-identical to its pre-#175 state (verified viagit diffagainst that commit).Validation
tofu init -backend=false && tofu validate: passes (pre-existing unrelated deprecation warnings only)tofu fmt: cleanyamllint --strict+pre-commit: cleanOnce merged
I'll dispatch a normal apply (or wait for the next scheduled run) to confirm the role and team binding actually get created live, then close #174/#176.
NO-ISSUE
Summary by CodeRabbit
New Features
Changes