refactor: modularize the vim engine into src/vim/ - #62
Open
oribarilan wants to merge 18 commits into
Open
Conversation
Enforce noExplicitAny, noConsole, and noNonNullAssertion as errors, turn on import sorting, and pin strict formatter options (semicolons, trailing commas, arrow parens). CI runs `biome ci --error-on-warnings`, so these now fail the build.
index.ts 395->408 after the :w/:write merge (#60); types/state/normal drift from the pending-state consolidation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the monolithic
src/vim.ts(656 lines) into a focusedsrc/vim/module tree behind a thin barrel, with tests split to mirror the layout. Rebased on v0.16.0.What changed
src/vim.tsbecomessrc/vim/with one concern per file:types,text,tables,util,state,insert,normal,visual, plus anindex.tsbarrel that re-exports only the public surface. Handlers stay pure; nothing undersrc/vim/touches the pluginapi.dgganddrxleft a dangling delete operator that corrupted the next motion.test/vim.test.tssplit into per-module suites undertest/vim/, plus a newtest/integration.test.tsfor the full pipeline.docs/plans/, and updated AGENTS.md to describe the new layout.Behavior
No user-facing behavior change beyond the dangling-operator fix. The
:w/:writefeature from #60 is untouched (it lives insrc/index.ts, outside the engine).Verification
just checkpasses locally: lint clean (24 files), 209 tests, 0 fail.