[OP-19787] Meeting invitation email shows event shifted by +1 hour for dates between 2026-09-29 and 2026-10-24 - #24512
Open
mrmir wants to merge 1 commit into
Conversation
Contributor
Author
|
@klaustopher @oliverguenther does this appear to make sense? I can't say I fully understand ical and all that comes with it, but with some claude-fu this appears to be a working fix. Is it at the correct place etc though? |
mrmir
marked this pull request as ready for review
July 30, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/OP-19787
What?
Limiting transitions to -6 months meant that the last relevant transition could be excluded when the transition happened more than 6 months ago, so anything after 2026-03-29 (when Europe/Berlin goes to summer time) + 6 months ends up without the transition.
When this transition isn't present, I think clients use different defaults, and perhaps that's why for the bug reporter downloaded ics events directly from OP work but email attachments don't (even though they are generated the exact same way). This I am not 100% sure about though...
Merge checklist