add support for auth via oidc mode - #508
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 81.48% 81.78% +0.29%
==========================================
Files 69 69
Lines 4365 4397 +32
Branches 511 515 +4
==========================================
+ Hits 3557 3596 +39
+ Misses 645 640 -5
+ Partials 163 161 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benoit74
requested changes
Sep 10, 2026
benoit74
approved these changes
Sep 10, 2026
benoit74
left a comment
Contributor
There was a problem hiding this comment.
LGTM, please ping me before merging this so that I switch prod config at the same moment
elfkuzco
force-pushed
the
oauth-oidc
branch
from
September 10, 2026 12:42
d06f314 to
160fb55
Compare
elfkuzco
force-pushed
the
oauth-oidc
branch
from
September 10, 2026 12:53
160fb55 to
3df8562
Compare
elfkuzco
force-pushed
the
oauth-oidc
branch
from
September 10, 2026 12:56
3df8562 to
77eea82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This is a port of openzim/zimfarm#2013 to the CMS to enable authentication via OIDC mechanism
Changes
sub(even for machines): whennameis unknown, simply usesubas display name until it gets updated by a Zimfarm adminOAUTH_OIDC_CLIENT_ID=>OAUTH_OIDC_AUDIENCE(we use it only to check audience in the JWT)OAUTH_SESSION_AUDIENCE_ID=>OAUTH_SESSION_AUDIENCE(audience ID is meaningless, it is an audience and a client ID ; choosing audience for clarity)CREATE_NEW_OAUTH_ACCOUNT=>OAUTH_CREATE_NEW_ACCOUNText.kiwix-aalandext.kiwix-nameclaimsaccess_tokeninstead of theid_token(save it in local storage + send it to the API)/oauth2/auth, specify theaudience(backend client ID) the access_token is intended forOAUTH_CLIENT_ID(the UI client ID) fromOAUTH_AUDIENCE(the backend client ID)This closes #506