Do not delete a course's html_temp directory when archiving it. - #3127
Merged
Alex-Jordan merged 1 commit intoAug 12, 2026
Merged
Conversation
There is no reason to delete this directory when a course is archived. It cannot be inside the course directory, since the webwork2 app does not serve these files from there, and so will not be contained in the archive in any case. So simply delete the line that does this deletion. It is not needed. Also remove the code for deleting some old "original default tmp" directory. If you still have such a directory in your course it is because you have restored some really old course archive file that has this directory, and it is time to upgrade your archives you are using. There is a statute of limitations on things like this. This obsolete code needs to go. This addresses issue openwebwork#3048.
drgrice1
force-pushed
the
archive-course-no-delete-html-temp
branch
from
August 11, 2026 23:56
2a5fe19 to
0827556
Compare
somiaj
approved these changes
Aug 12, 2026
Alex-Jordan
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to delete this directory when a course is archived. It cannot be inside the course directory, since the webwork2 app does not serve these files from there, and so will not be contained in the archive in any case. So simply delete the line that does this deletion. It is not needed.
Also remove the code for deleting some old "original default tmp" directory. If you still have such a directory in your course it is because you have restored some really old course archive file that has this directory, and it is time to upgrade the archives you are using. There is a statute of limitations on things like this. This obsolete code needs to go.
This addresses issue #3048.