C2: review-lane-pin lockstep diverged after #1138 (core fe9a6f5b, MIGRATION_PIN b21f0100)

[brettheap]

Lane: openxfactory-5 (openXfactory-5)

C2: lockstep.status goes converged to diverged in contracts/review-lane-pin.yaml, with its test literal, after #1138 landed as 9171d14a. DRAFT, for review.

Authority

• Brett Heap's ruling on openxFactory openDox + openXdox: two open-source layers, an installable app with users, projects and a database; domain descendants pin openXdox (Brett's ruling 2026-09-04) #656, comment 5815412869 ("(a) on C1–C5"), item C2: the lockstep residue is "owed the moment Advance the pinned decision core to fe9a6f5b91886e4f07296dc6a264deb345b1618f #1138 (or whichever repin moves core_commit off MIGRATION_PIN) lands".
• Lane openxfactory-4 released C2 to this lane at comment 6023711538; this lane claimed it at 6023723446.

Why it is owed

• 9171d14a (Advance the pinned decision core to fe9a6f5b91886e4f07296dc6a264deb345b1618f #1138, the review-lane-repin lane's PR, landed on Brett's word "land Advance the pinned decision core to fe9a6f5b91886e4f07296dc6a264deb345b1618f #1138 when green") moved contracts/review-lane-pin.yaml core_commit from b21f0100 to fe9a6f5b, the codexFactory A validated chain is not an audit trail, it is a permission — realize tranche one #524 merge.
• The xFactory aggregation's MIGRATION_PIN stays b21f0100 at all three surfaces, measured at xFactory main 1047586d: .github/workflows/merge-master-approval.yml:152, .github/workflows/council-convening-lane.yml:308 and tests/test_merge_master_workflows.py:72.
• So lockstep.status: converged was false while every test stayed green. scripts/review_lane_repin.py never writes lockstep (zero occurrences), which is why nothing else records it.

What changes: exactly two files, in the form of #1123 → 8184d74a

file	change
contracts/review-lane-pin.yaml	lockstep.status converged → diverged (the only removed line); one dated reason paragraph appended at the end of reason:, before converged_with:
tests/review_lane_pin/test_review_lane_caller.py	the test_the_pin_records_its_lockstep_state_with_the_aggregation_pin literal converged → diverged in the same commit; one dated paragraph appended to that test's docstring

The reason paragraph is dated 2026-10-06 and names #1138 → 9171d14a, core_commit fe9a6f5b, MIGRATION_PIN b21f0100, the ruling 5815412869 (a), and #1145 (assert-review-lane-lockstep-against-aggregation, merged 2026-09-23 as a Status: draft packet, so nothing yet measures the state). Every commit id in it is written SHORT: test_the_pin_carries_exactly_one_commit_shaped_value permits exactly one 40-hex token, and that is core_commit.

Authoring: lane 4's make-lockstep-paragraph.sh (copied into lane 5's tools with lane 4's consent), --reason-mode routine --pr 1138 --emit append, exit 0, against live main. Its paragraph was then hand-adjusted to add the #1138 merge sha, the ruling, the xFactory main measurement and the #1145 wording, and to drop its ambiguous "(a)-class" phrase.

What does not change

• MIGRATION_PIN is NOT moved. Re-converging is a separate re-point ceremony in the xFactory aggregation, on an explicit word.
• core_commit, the floor snapshot, obligation: and converged_with: are untouched. Checked by parsing both versions: obligation and converged_with identical, every other top-level key identical, the old reason text preserved as a prefix.
• specs/025-openxfactory-review-lane-caller/tasks.md task 6.5 (a ledger row, unticked) is not edited here. It was brought current through the 2026-09-21 convergence by lockstep converges at the fourth re-point ceremony: status, its test literal, and the specs/025 row #1136, and this transition makes it one transition stale again, as lockstep re-diverges after the repin lane's advance: status and its test literal move together, plus the stale refresh: path #1123 left it. Left for whoever next touches that row.

Evidence

Run in a fresh full clone named openxFactory, with the pinned core checked out at fe9a6f5b (PINNED_CORE_CHECKOUT; its floor document's sha256 f2bc7d92…ec96 equals the pin's), TMPDIR and --basetemp under ~/.local/state.

check	main (9171d14a)	this branch
pytest tests/review_lane_pin/ -m "not postgres"	200 passed, 75 subtests passed	200 passed, 75 subtests passed
python3 scripts/validate-openspec-cli-pin.py --all --strict	exit 0, 113 passed, 1 failed (the one dispositioned exception), output identical	exit 0, 113 passed, 1 failed (the same exception), output identical
tests/review_lane_pin + tests/doc-health + tests/sequenced_after + tests/estate_inventory	the same 8 tests fail (listed below)	2709 passed, 1 skipped, 8 failed, 75 subtests passed; the same 8

The 8 failures are identical on main and pre-existing in this environment (the clone has no openDox/openXdox submodule checkouts): test_ideation_readiness.py (3), test_readiness_dispatch.py::test_merge_wires_the_real_validator_for_a_genuinely_scored_index, test_sentinel_vocabulary.py (2), test_status_reader_real_lines.py::test_the_reader_finds_what_the_writer_just_wrote_through_an_exotic_header, test_tag_hygiene_pinned_targets.py::test_a_lexically_malformed_value_builds_no_path_and_reads_nothing.

CI is the gate for the full suite.

🤖 Generated with Claude Code

Summary by Sourcery

Record the review-lane lockstep divergence caused by the core pin advancing ahead of the aggregation migration pin.

Bug Fixes:

• Record the review-lane pin as diverged when its core commit advances away from the aggregation migration pin.

Enhancements:

• Document the divergence and its provenance in the contract while preserving the existing convergence obligations and comparison targets.
• Update the lockstep contract test to assert the new diverged state and explain the transition.

Tests:

• Update review-lane pin coverage for the re-diverged lockstep state.

[sourcery-ai]

Reviewer's Guide

This PR synchronizes the review-lane pin contract and its test with the post-#1138 state: core_commit is now fe9a6f5b while the aggregation remains pinned to b21f0100, so lockstep is explicitly recorded as diverged without moving the aggregation pin or changing convergence obligations.

File-Level Changes

Change	Details	Files
Record the review-lane pin as diverged after the repin moved core_commit away from the aggregation’s unchanged MIGRATION_PIN.	Change lockstep.status from converged to diverged. Append dated provenance explaining PR Advance the pinned decision core to fe9a6f5b91886e4f07296dc6a264deb345b1618f #1138, the two commit pins, the governing C2 ruling, and the absence of an active measurement mechanism. Leave core_commit, migration pin references, obligation, floor snapshot, and convergence metadata unchanged.	contracts/review-lane-pin.yaml
Update the lockstep contract test to assert and document the newly divergent state.	Change the expected lockstep literal from converged to diverged. Append matching transition context to the test docstring.	tests/review_lane_pin/test_review_lane_caller.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[Copilot]

Copilot review overview

🔵 Needs a closer look

The contract change depends on private cross-repository state and governance authority requiring human verification.

Review effort: Balanced
Findings: None

What changed in this PR

Records the review-lane pin’s renewed divergence after the core pin advanced beyond the aggregation migration pin.

Changes:

• Changes lockstep.status from converged to diverged and records provenance.
• Updates the corresponding test literal and historical explanation.

File	Description
contracts/​review-lane-pin.yaml	Records the divergence and its cause.
tests/​review_lane_pin/​test_review_lane_caller.py	Updates the expected state and transition history.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sourcery-ai]

Sorry @brettheap, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 18 hours and 39 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

[brettheap]

Lane: openxfactory-5 (openXfactory-5)

LANDING — lane openXfactory-5, session bbe4d255-02db-4578-840b-09924442e544@Eagle, 2026-10-06T23:02:32Z, PR #1256 into opensoft/openxFactory main

[brettheap]

Lane: openxfactory-5 (openXfactory-5)

LANDED — lane openXfactory-5, session bbe4d255-02db-4578-840b-09924442e544@Eagle, 2026-10-06T23:02:54Z, PR #1256 into opensoft/openxFactory main → merge 8c1eeae; C2: review-lane-pin lockstep diverged after #1138 (core fe9a6f5b, MIGRATION_PIN b21f0100)