Skip to content

stackrox: add OCP 5.0 AWS dual-stack e2e tests - #83134

Open
davdhacs wants to merge 2 commits into
openshift:mainfrom
davdhacs:davdhacs/ocp5-aws-dualstack
Open

stackrox: add OCP 5.0 AWS dual-stack e2e tests#83134
davdhacs wants to merge 2 commits into
openshift:mainfrom
davdhacs:davdhacs/ocp5-aws-dualstack

Conversation

@davdhacs

@davdhacs davdhacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

/uncc

Test ACS on OCP 5.0 with AWS dual-stack networking. On 5.0, dual-stack is GA (AWSDualStackInstall feature gate is in inDefault()), so no featureSet: TechPreviewNoUpgrade is needed.

Jobs:

  • dual-qa-e2e-tests / dual-nongroovy-e2e-tests — dual-stack IPv4-primary
  • dual-ipv6-primary-qa-e2e-tests / dual-ipv6-primary-nongroovy-e2e-tests — dual-stack IPv6-primary

IPv6-only is not supported on AWS even on 5.0 (installer rejects single-stack IPv6 on cloud platforms).

Uses openshift-4-latest automation-flavors tag with CLOUD_PROVIDER=aws and NETWORK_STACK.

ROX-10856

Summary by CodeRabbit

Adds StackRox CI coverage for OCP 5.0 on AWS with dual-stack networking.

  • Adds IPv4-primary and IPv6-primary QA and non-Groovy E2E jobs.
  • Uses the openshift-4-latest automation-flavors tag with CLOUD_PROVIDER=aws and NETWORK_STACK.
  • Enables dual-stack testing without TechPreviewNoUpgrade.
  • Extends the OCP 4 E2E workflow to accept the new environment variables.

Test ACS on OCP 5.0 with AWS dual-stack networking (both IPv4-primary
and IPv6-primary). On 5.0, dual-stack is GA — no TechPreviewNoUpgrade
needed.

IPv6-only remains unsupported on AWS even on 5.0 (installer still
rejects single-stack IPv6 on cloud platforms).

ROX-10856

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-master-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 516d292d-be16-4ff1-af3f-4273708c4cfb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The PR adds StackRox OCP 5.0 AWS dual-stack CI configuration. It defines build settings and four optional E2E jobs. It also adds default network variables to the OCP 4 creation step.

Changes

StackRox dual-stack CI

Layer / File(s) Summary
Workflow environment defaults
ci-operator/step-registry/stackrox/automation-flavors/ocp-4-e2e/stackrox-automation-flavors-ocp-4-e2e-workflow.yaml
The ocp-4-create step defines empty-default CLOUD_PROVIDER and NETWORK_STACK variables.
Dual-stack CI configuration
ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-5-0-aws-dualstack.yaml
The configuration defines images, resource requests, the test-binary build command, four optional AWS dual-stack E2E jobs, and generated repository metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant StackRoxCIConfig
  participant ocp4create as ocp-4-create
  participant AWSDualStackE2E as AWS dual-stack E2E jobs
  StackRoxCIConfig->>ocp4create: define CLOUD_PROVIDER and NETWORK_STACK defaults
  StackRoxCIConfig->>AWSDualStackE2E: configure OCP 5.0 dual-stack test jobs
  AWSDualStackE2E->>AWSDualStackE2E: run QA and non-Groovy suites
Loading

Possibly related PRs

  • openshift/release#83132: Adds a similar StackRox AWS dual-stack CI configuration and modifies the same workflow environment variables.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding OCP 5.0 AWS dual-stack end-to-end tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only three YAML CI files; searches found no Ginkgo title APIs or dynamic title expressions. Added job names and network values are static CI identifiers.
Test Structure And Quality ✅ Passed The pull request changes only two CI YAML files; it adds no Ginkgo test code, It blocks, cluster operations, or assertions to review.
Microshift Test Compatibility ✅ Passed The commit adds only CI YAML and presubmit entries; the full patch contains no Ginkgo It, Describe, Context, or When test definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only YAML CI configuration and workflow files; it adds no Ginkgo test declarations or test bodies that require SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI test configuration, workflow environment variables, and generated Prow job specs; it adds no operator, controller, deployment, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only three YAML CI files; searches found no OTE process entry points or stdout APIs such as RunSpecs, klog, fmt.Print, or os.Stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds only CI YAML and generated Prow jobs; it adds no Ginkgo test code, IPv4 literals, URL construction, or external-connectivity commands.
No-Weak-Crypto ✅ Passed The PR adds only CI YAML for AWS dual-stack jobs and environment defaults; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons appear in added content.
Container-Privileges ✅ Passed Changed YAML adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, securityContext, capability, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds no logging commands or secret values; it only passes aws, network, version, and test-suite settings, while existing echo lines remain generic.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davdhacs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davdhacs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-nongroovy-e2e-tests stackrox/stackrox presubmit Presubmit changed
pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-qa-e2e-tests stackrox/stackrox presubmit Presubmit changed
pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-nongroovy-e2e-tests stackrox/stackrox presubmit Presubmit changed
pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-qa-e2e-tests stackrox/stackrox presubmit Presubmit changed
pull-ci-stackrox-stackrox-master-ocp-5-0-qa-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-scanner-v4-install-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-operator-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-ui-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-fips-qa-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-compliance-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-nongroovy-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-5-0-vm-scanning-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-qa-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-scanner-v4-install-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-operator-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-ui-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-compliance-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-stable-scanner-v4-install-nongroovy-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-qa-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-scanner-v4-install-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-operator-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-ui-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-fips-qa-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-compliance-e2e-tests stackrox/stackrox presubmit Registry content changed
pull-ci-stackrox-stackrox-master-ocp-dev-preview-nongroovy-e2e-tests stackrox/stackrox presubmit Registry content changed

A total of 160 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@davdhacs

davdhacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-qa-e2e-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs

davdhacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-qa-e2e-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs

davdhacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-nongroovy-e2e-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs

davdhacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-nongroovy-e2e-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@davdhacs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stackrox/stackrox/master/ocp-5-0-aws-dualstack-dual-ipv6-primary-qa-e2e-tests c379398 link unknown /pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-qa-e2e-tests
ci/rehearse/stackrox/stackrox/master/ocp-5-0-aws-dualstack-dual-nongroovy-e2e-tests c379398 link unknown /pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-nongroovy-e2e-tests
ci/rehearse/stackrox/stackrox/master/ocp-5-0-aws-dualstack-dual-ipv6-primary-nongroovy-e2e-tests c379398 link unknown /pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-ipv6-primary-nongroovy-e2e-tests
ci/rehearse/stackrox/stackrox/master/ocp-5-0-aws-dualstack-dual-qa-e2e-tests c379398 link unknown /pj-rehearse pull-ci-stackrox-stackrox-master-ocp-5-0-aws-dualstack-dual-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant