Fix TLS scanner tests broken by variable name changes

[joelsmith]

Ever since #82865 merged, our tests have been broken. It would have been nice if that PR had just updated the handful of tests using the options it "deprecated" instead of breaking them. Let's run some rehearsals and see if this gets our tests passing again.

Summary by CodeRabbit

• Updated AWS e2e TLS scanner configurations for four OpenShift component repositories.
• Replaced combined SCANNER_CPU and SCANNER_MEMORY variables with separate CPU and memory limit/request variables.
• Aligns CI configuration with variable renames from PR #82865 and restores affected TLS scanner tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e5070d19-6114-4f5b-951b-18212c5b5484

📥 Commits

Reviewing files that changed from the base of the PR and between 916113d and b03d764.

📒 Files selected for processing (4)

• ci-operator/config/openshift/cluster-autoscaler-operator/openshift-cluster-autoscaler-operator-main.yaml
• ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml
• ci-operator/config/openshift/custom-metrics-autoscaler-operator/openshift-custom-metrics-autoscaler-operator-main.yaml
• ci-operator/config/openshift/vertical-pod-autoscaler-operator/openshift-vertical-pod-autoscaler-operator-main.yaml

---

Walkthrough

The AWS e2e test configurations replace combined scanner CPU and memory variables with separate CPU and memory limit and request variables.

Changes

Scanner resource configuration

Layer / File(s)	Summary
Separate scanner resource settings ci-operator/config/openshift/*/*-main.yaml	Four operator configurations replace SCANNER_CPU and SCANNER_MEMORY with separate CPU and memory limit and request variables. The cluster autoscaler configuration sets CPU to 500m and memory to 1Gi.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: shyadav10

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes fixing TLS scanner tests affected by variable name changes, which matches the main pull request change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes four static YAML scanner environment mappings; the diff adds no It, Describe, Context, or When test titles and no dynamic test-name values.
Test Structure And Quality	✅ Passed	The pull request changes only four YAML CI configurations; it adds no Ginkgo test code or It blocks to assess against these requirements.
Microshift Test Compatibility	✅ Passed	The PR changes only four CI YAML files for TLS scanner variables and adds no Ginkgo e2e tests or test declarations requiring MicroShift API review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only four CI YAML files, replacing TLS scanner environment variables; it adds no Ginkgo e2e tests or topology assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only TLS scanner CPU/memory environment variables in four CI YAML files; it adds no deployment, replica, affinity, topology spread, node, toleration, or PDB constraints.
Ote Binary Stdout Contract	✅ Passed	The commit changes only four YAML environment blocks. It adds no Go, shell, or executable code and no process-level stdout or logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes only four YAML scanner environment blocks. It adds no Ginkgo tests, IPv4 literals, URLs, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The patch only renames TLS scanner resource variables in four YAML files; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The patch only renames scanner resource environment variables in four CI YAML files; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only changes TLS scanner resource environment names and values in four YAML jobs; it adds no logging commands or passwords, tokens, API keys, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@joelsmith: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm	openshift/cluster-resource-override-admission-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws	openshift/cluster-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn	openshift/custom-metrics-autoscaler-operator	presubmit	Ci-operator config changed
pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm	openshift/vertical-pod-autoscaler-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[joelsmith]

/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm

[openshift-merge-bot]

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jkyros]

The only risk here is if it stays broken 😁
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-autoscaler-operator/OWNERS [joelsmith]
• ci-operator/config/openshift/cluster-resource-override-admission-operator/OWNERS [jkyros,joelsmith]
• ci-operator/config/openshift/custom-metrics-autoscaler-operator/OWNERS [joelsmith]
• ci-operator/config/openshift/vertical-pod-autoscaler-operator/OWNERS [jkyros,joelsmith]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelsmith]

/pj-rehearse ack

[openshift-merge-bot]

@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.