[release-controller] Adding default release configs for OKD ARM64 - #83131
[release-controller] Adding default release configs for OKD ARM64#83131bradmwilliams wants to merge 1 commit into
Conversation
rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
WalkthroughThe change adds ARM64 OKD and SCOS release-controller configurations for stable, next, artifact, and CI streams. It also wires ARM64 annotations and monitors the ARM64 origin release endpoint. ChangesARM64 release streams
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json`:
- Around line 19-23: Update the tagRef.name values in
core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json
(lines 19-23) from scos-5.0 to scos-5.0-ci, and in
core-services/release-controller/_releases/release-okd-scos-5.1-ci-arm64.json
(lines 19-23) from scos-5.1 to scos-5.1-ci.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 49618e0f-66ab-4166-a031-dd26eef17b6b
📒 Files selected for processing (17)
clusters/app.ci/openshift-user-workload-monitoring/blackbox_probe.yamlcore-services/release-controller/_releases/release-okd-4.y-stable-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.21-art-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.21-ci-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.22-art-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.22-ci-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.23-art-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.23-ci-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.y-next-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-4.y-stable-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.0-art-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.1-art-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.1-ci-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.y-next-arm64.jsoncore-services/release-controller/_releases/release-okd-scos-5.y-stable-arm64.jsonhack/annotate.sh
| "tag": { | ||
| "tagRef": { | ||
| "name": "scos-5.0" | ||
| } | ||
| } |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Publish the 5.x CI streams with CI tag names.
Both files define CI release streams but publish generic tags. This diverges from the 4.21–4.23 CI configurations. Consumers of scos-5.0-ci and scos-5.1-ci will not receive these ARM64 CI releases.
core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json#L19-L23: changescos-5.0toscos-5.0-ci.core-services/release-controller/_releases/release-okd-scos-5.1-ci-arm64.json#L19-L23: changescos-5.1toscos-5.1-ci.
📍 Affects 2 files
core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json#L19-L23(this comment)core-services/release-controller/_releases/release-okd-scos-5.1-ci-arm64.json#L19-L23
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json`
around lines 19 - 23, Update the tagRef.name values in
core-services/release-controller/_releases/release-okd-scos-5.0-ci-arm64.json
(lines 19-23) from scos-5.0 to scos-5.0-ci, and in
core-services/release-controller/_releases/release-okd-scos-5.1-ci-arm64.json
(lines 19-23) from scos-5.1 to scos-5.1-ci.
|
@bradmwilliams: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, jupierce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
Summary by CodeRabbit