Skip to content

OCPNETUI-56: Add Cypress page objects and test constants - #469

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
lkladnit:lkladnit/cypress-views
Aug 19, 2026
Merged

OCPNETUI-56: Add Cypress page objects and test constants#469
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
lkladnit:lkladnit/cypress-views

Conversation

@lkladnit

Copy link
Copy Markdown
Contributor

Summary

Add view helpers and constants for networking E2E tests:

  • Views: NAD form helpers, UDN form helpers, common selectors, actions
  • Constants: base test values, NAD config constants
  • Types: NAD type definitions

These are the page object layer used by test specs (next PR).

PR 2 of 3 in the Cypress E2E series (1a: infra, 1b: views, 1c: tests).
Depends on #468.

Jira: OCPNETUI-56

Test plan

  • TypeScript compiles without errors
  • No lint violations in new files

Made with Cursor

Set up Cypress test infrastructure for networking plugin E2E tests:
- cypress.config.js with esbuild preprocessor, timeouts, reporter
- Support files: login commands, navigation helpers, selectors
- Plugin config with dotenv and webpack preprocessor
- ESLint, tsconfig, reporter config for the test suite
- .env.example with required environment variables
- Package deps: esbuild-loader, dotenv, cypress-multi-reporters
- Minor fixes in integration-tests/ login and example spec

Jira: OCPNETUI-56
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 12, 2026

Copy link
Copy Markdown

@lkladnit: This pull request references OCPNETUI-56 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add view helpers and constants for networking E2E tests:

  • Views: NAD form helpers, UDN form helpers, common selectors, actions
  • Constants: base test values, NAD config constants
  • Types: NAD type definitions

These are the page object layer used by test specs (next PR).

PR 2 of 3 in the Cypress E2E series (1a: infra, 1b: views, 1c: tests).
Depends on #468.

Jira: OCPNETUI-56

Test plan

  • TypeScript compiles without errors
  • No lint violations in new files

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkladnit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 258ef26b-0b50-4617-85d0-623d7da2b0ee


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lkladnit
lkladnit force-pushed the lkladnit/cypress-views branch from f695767 to 7a328e9 Compare August 13, 2026 09:43
@lkladnit lkladnit changed the title OCPNETUI-56: Add Cypress page objects and test constants WIP: OCPNETUI-56: Add Cypress page objects and test constants Aug 13, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
@lkladnit
lkladnit force-pushed the lkladnit/cypress-views branch 4 times, most recently from 9f9a58e to 318170b Compare August 13, 2026 12:47
@lkladnit
lkladnit marked this pull request as draft August 13, 2026 14:51
@lkladnit lkladnit self-assigned this Aug 13, 2026
@lkladnit lkladnit changed the title WIP: OCPNETUI-56: Add Cypress page objects and test constants OCPNETUI-56: Add Cypress page objects and test constants Aug 13, 2026
@lkladnit lkladnit removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@pcbailey
pcbailey marked this pull request as ready for review August 17, 2026 13:25
@openshift-ci
openshift-ci Bot requested a review from batyana August 17, 2026 13:25
@pcbailey

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7d9d46b and 2 for PR HEAD 318170b in total

Add view helpers and constants for networking E2E tests:
- Views: NAD form helpers, UDN form helpers, common selectors, actions
- Constants: base test values, NAD config constants
- Types: NAD type definitions

These are the page object layer used by test specs (next PR).

Jira: OCPNETUI-56
Co-authored-by: Cursor <cursoragent@cursor.com>
@lkladnit
lkladnit force-pushed the lkladnit/cypress-views branch from 318170b to 66c2497 Compare August 18, 2026 08:10
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@pcbailey

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

@lkladnit: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 5070a06 into openshift:main Aug 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants