OCPBUGS-105316: Fix flaky PollConsoleUpdates e2e test timeout in CI

[rhamilto]

Analysis / Root cause:

The Playwright e2e test "triggers the console update toast when a plugin is added and a different plugin endpoint is erroring" in poll-console-updates.spec.ts flakes in CI with Test timeout of 120000ms exceeded.

The test requires multiple 15-second polling cycles to complete:

• Init: 2 poll cycles (~30s)
• Detect new plugin: 1 poll cycle (~15s)
• Endpoint readiness retry: 1+ poll cycles (~15s+)

Under ideal conditions this totals ~60–75s, but in CI the OAuth redirect flow and slower environment add significant overhead. The navigateAndWaitForInit helper alone allows up to 90s for init, leaving very little of the default 120s test timeout for the remaining assertions. When a mid-test auth redirect occurs, the PollConsoleUpdates component remounts and needs additional poll cycles to re-initialize, pushing past the 120s limit.

Additionally, page.waitForResponse had no explicit timeout and no status code filter, making it possible to match stale or non-200 responses.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105316

Solution description:

• Add test.setTimeout(300_000) to give CI ample headroom for the multi-cycle polling sequence plus potential auth redirects.
• Add explicit { timeout: 30_000 } and resp.status() === 200 filter to waitForResponse for more robust synchronization with the poll cycle.

Screenshots / screen recording:

N/A — no visual changes.

Test setup:

Console running at localhost:9000.

Test cases:

• Ran the specific test 3x with --repeat-each=3 — all 3 passed.
• Ran all 5 tests in poll-console-updates.spec.ts — all passed with no regressions.

Browser conformance:

N/A — test-only change, no UI changes.

Additional info:

N/A

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Improved end-to-end test reliability by allowing more time for plugin endpoint error scenarios.
  • Updated polling checks to proceed only after receiving a successful response.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-105316, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

The Playwright e2e test "triggers the console update toast when a plugin is added and a different plugin endpoint is erroring" in poll-console-updates.spec.ts flakes in CI with Test timeout of 120000ms exceeded.

The test requires multiple 15-second polling cycles to complete:

• Init: 2 poll cycles (~30s)
• Detect new plugin: 1 poll cycle (~15s)
• Endpoint readiness retry: 1+ poll cycles (~15s+)

Under ideal conditions this totals ~60–75s, but in CI the OAuth redirect flow and slower environment add significant overhead. The navigateAndWaitForInit helper alone allows up to 90s for init, leaving very little of the default 120s test timeout for the remaining assertions. When a mid-test auth redirect occurs, the PollConsoleUpdates component remounts and needs additional poll cycles to re-initialize, pushing past the 120s limit.

Additionally, page.waitForResponse had no explicit timeout and no status code filter, making it possible to match stale or non-200 responses.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105316

Solution description:

• Add test.setTimeout(300_000) to give CI ample headroom for the multi-cycle polling sequence plus potential auth redirects.
• Add explicit { timeout: 30_000 } and resp.status() === 200 filter to waitForResponse for more robust synchronization with the poll cycle.

Screenshots / screen recording:

N/A — no visual changes.

Test setup:

Console running at localhost:9000.

Test cases:

• Ran the specific test 3x with --repeat-each=3 — all 3 passed.
• Ran all 5 tests in poll-console-updates.spec.ts — all passed with no regressions.

Browser conformance:

N/A — test-only change, no UI changes.

Additional info:

N/A

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 94bc36f4-d5f2-4cca-b19e-7535209e58e8

📥 Commits

Reviewing files that changed from the base of the PR and between d437c09 and 6d8b442.

📒 Files selected for processing (1)

• frontend/e2e/tests/console/app/poll-console-updates.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• frontend/e2e/tests/console/app/poll-console-updates.spec.ts

---

Walkthrough

The console update polling tests now allow 300 seconds for the suite. The plugin endpoint test requires an HTTP 200 response from /api/check-updates within 30 seconds.

Changes

Console update polling tests

Layer / File(s)	Summary
Polling timeout and response validation frontend/e2e/tests/console/app/poll-console-updates.spec.ts	The suite timeout is 300 seconds. The plugin endpoint test now matches /api/check-updates responses with HTTP status 200 and retains its 30-second timeout.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: leo6leo, therealjon

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the flaky PollConsoleUpdates e2e test and the CI timeout fix.
Description check	✅ Passed	The description covers the root cause, solution, setup, test cases, visual impact, browser status, Jira reference, and additional information.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The changed Playwright suite uses static literal titles; no title contains dynamic interpolation, timestamps, UUIDs, IPs, or generated run-specific values.
Test Structure And Quality	✅ Passed	Not applicable: the target is a Playwright TypeScript spec importing @playwright/test, not Ginkgo code using It, BeforeEach, or Eventually.
Microshift Test Compatibility	✅ Passed	The commit only modifies an existing Playwright TypeScript suite; it adds no Ginkgo tests and references no MicroShift-unavailable OpenShift APIs or namespaces.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes a Playwright TypeScript test timeout and response predicate; it adds no Ginkgo e2e tests or multi-node/SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Not applicable: the patch only changes Playwright test timeout and response matching; it adds no deployment, operator, controller, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a Playwright TypeScript spec; its changed code has no stdout writes, logging setup, or OTE process-level hooks such as main, BeforeSuite, or RunSpecs.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The change is in an existing Playwright TypeScript suite, not a new Ginkgo test; the file has no IPv4 literals or external/public network endpoints.
No-Weak-Crypto	✅ Passed	The commit changes only Playwright timeout placement and comments; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The PR changes only a Playwright TypeScript test; the patch adds no container or Kubernetes manifest and contains no flagged privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only changes Playwright timeout and response filtering; it adds no logging calls or sensitive data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[rhamilto]

/jira refresh
/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-105316, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh
/pipeline required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-105316, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Analysis / Root cause:

The Playwright e2e test "triggers the console update toast when a plugin is added and a different plugin endpoint is erroring" in poll-console-updates.spec.ts flakes in CI with Test timeout of 120000ms exceeded.

The test requires multiple 15-second polling cycles to complete:

• Init: 2 poll cycles (~30s)
• Detect new plugin: 1 poll cycle (~15s)
• Endpoint readiness retry: 1+ poll cycles (~15s+)

Under ideal conditions this totals ~60–75s, but in CI the OAuth redirect flow and slower environment add significant overhead. The navigateAndWaitForInit helper alone allows up to 90s for init, leaving very little of the default 120s test timeout for the remaining assertions. When a mid-test auth redirect occurs, the PollConsoleUpdates component remounts and needs additional poll cycles to re-initialize, pushing past the 120s limit.

Additionally, page.waitForResponse had no explicit timeout and no status code filter, making it possible to match stale or non-200 responses.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105316

Solution description:

• Add test.setTimeout(300_000) to give CI ample headroom for the multi-cycle polling sequence plus potential auth redirects.
• Add explicit { timeout: 30_000 } and resp.status() === 200 filter to waitForResponse for more robust synchronization with the poll cycle.

Screenshots / screen recording:

N/A — no visual changes.

Test setup:

Console running at localhost:9000.

Test cases:

• Ran the specific test 3x with --repeat-each=3 — all 3 passed.
• Ran all 5 tests in poll-console-updates.spec.ts — all passed with no regressions.

Browser conformance:

N/A — test-only change, no UI changes.

Additional info:

N/A

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
• Improved end-to-end test reliability by allowing more time for plugin endpoint error scenarios.
• Updated polling checks to proceed only after receiving a successful response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[rhamilto]

/test e2e-gcp-console-techpreview

[rhamilto]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[rhamilto]

/test e2e-gcp-console-techpreview

[rhamilto]

Take 3: vikram-raj#17

[logonoff]

/lgtm

[openshift-merge-bot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[rhamilto]

/pipeline required

Latest failure should be fixed by #16914

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[rhamilto]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-playwright

[rhamilto]

/retest

[logonoff]

/label tide/merge-method-squash
/lgtm

[openshift-merge-bot]

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/verified by ci

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-105316
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-105316 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Analysis / Root cause:

The Playwright e2e test "triggers the console update toast when a plugin is added and a different plugin endpoint is erroring" in poll-console-updates.spec.ts flakes in CI with Test timeout of 120000ms exceeded.

The test requires multiple 15-second polling cycles to complete:

• Init: 2 poll cycles (~30s)
• Detect new plugin: 1 poll cycle (~15s)
• Endpoint readiness retry: 1+ poll cycles (~15s+)

Under ideal conditions this totals ~60–75s, but in CI the OAuth redirect flow and slower environment add significant overhead. The navigateAndWaitForInit helper alone allows up to 90s for init, leaving very little of the default 120s test timeout for the remaining assertions. When a mid-test auth redirect occurs, the PollConsoleUpdates component remounts and needs additional poll cycles to re-initialize, pushing past the 120s limit.

Additionally, page.waitForResponse had no explicit timeout and no status code filter, making it possible to match stale or non-200 responses.

Jira: https://redhat.atlassian.net/browse/OCPBUGS-105316

Solution description:

• Add test.setTimeout(300_000) to give CI ample headroom for the multi-cycle polling sequence plus potential auth redirects.
• Add explicit { timeout: 30_000 } and resp.status() === 200 filter to waitForResponse for more robust synchronization with the poll cycle.

Screenshots / screen recording:

N/A — no visual changes.

Test setup:

Console running at localhost:9000.

Test cases:

• Ran the specific test 3x with --repeat-each=3 — all 3 passed.
• Ran all 5 tests in poll-console-updates.spec.ts — all passed with no regressions.

Browser conformance:

N/A — test-only change, no UI changes.

Additional info:

N/A

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
• Improved end-to-end test reliability by allowing more time for plugin endpoint error scenarios.
• Updated polling checks to proceed only after receiving a successful response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.