Skip to content

Move GCD to TechPreview #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickdillon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move GCD to TechPreview #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...ed.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,6 +2066,28 @@ spec:
- message: resourceTags are immutable and may only be configured
during installation
rule: self.all(x, x in oldSelf) && oldSelf.all(x, x in self)
universeDomain:
description: |-
universeDomain is the GCP universe domain for the cluster, detected from
the installer credentials. Components with their own GCP credentials should
read the universe domain from those credentials, as they are the authoritative
source. This field is provided for components that do not have GCP credentials
and for general observability.

When omitted, standard public GCP (googleapis.com) is assumed.

universeDomain is an optional field that, when specified, must be non-empty and at most
253 characters. It must be a valid DNS subdomain: containing only lowercase alphanumeric
characters, '-' or '.', and starting and ending with an alphanumeric character.
maxLength: 253
minLength: 1
type: string
x-kubernetes-validations:
- message: 'universeDomain must be a valid DNS subdomain:
contain no more than 253 characters, contain only lowercase
alphanumeric characters, ''-'' or ''.'', and start and
end with an alphanumeric character'
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
type: object
x-kubernetes-validations:
- message: resourceLabels may only be configured during installation
Expand Down
2 changes: 1 addition & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
| ClusterUpdatePreflight| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| ConfidentialCluster| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| Example2| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| GCPSovereignCloudInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| MachineAPIMigrationVSphere| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| NetworkConnect| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| NewOLMBoxCutterRuntime| | | | <span style="background-color: #519450">Enabled</span> | | | | <span style="background-color: #519450">Enabled</span> |
Expand Down Expand Up @@ -63,6 +62,7 @@
| GCPCustomAPIEndpoints| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GCPCustomAPIEndpointsInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GCPDualStackInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GCPSovereignCloudInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| GatewayAPIManagementMode| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| HyperShiftOnlyDynamicResourceAllocation| <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | |
| ImageModeStatusReporting| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ var (
contactPerson("barbacbd").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1977").
enable(inDevPreviewNoUpgrade()).
enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureCBORServingAndStorage = newFeatureGate("CBORServingAndStorage").
Expand Down
22 changes: 22 additions & 0 deletions ...d.crd-manifests/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,6 +2368,28 @@ spec:
be configured during installation
rule: self.all(x, x in oldSelf) && oldSelf.all(x,
x in self)
universeDomain:
description: |-
universeDomain is the GCP universe domain for the cluster, detected from
the installer credentials. Components with their own GCP credentials should
read the universe domain from those credentials, as they are the authoritative
source. This field is provided for components that do not have GCP credentials
and for general observability.

When omitted, standard public GCP (googleapis.com) is assumed.

universeDomain is an optional field that, when specified, must be non-empty and at most
253 characters. It must be a valid DNS subdomain: containing only lowercase alphanumeric
characters, '-' or '.', and starting and ending with an alphanumeric character.
maxLength: 253
minLength: 1
type: string
x-kubernetes-validations:
- message: 'universeDomain must be a valid DNS subdomain:
contain no more than 253 characters, contain only
lowercase alphanumeric characters, ''-'' or ''.'',
and start and end with an alphanumeric character'
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
type: object
x-kubernetes-validations:
- message: resourceLabels may only be configured during
Expand Down
22 changes: 22 additions & 0 deletions ...d-manifests/crds/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,6 +2066,28 @@ spec:
- message: resourceTags are immutable and may only be configured
during installation
rule: self.all(x, x in oldSelf) && oldSelf.all(x, x in self)
universeDomain:
description: |-
universeDomain is the GCP universe domain for the cluster, detected from
the installer credentials. Components with their own GCP credentials should
read the universe domain from those credentials, as they are the authoritative
source. This field is provided for components that do not have GCP credentials
and for general observability.

When omitted, standard public GCP (googleapis.com) is assumed.

universeDomain is an optional field that, when specified, must be non-empty and at most
253 characters. It must be a valid DNS subdomain: containing only lowercase alphanumeric
characters, '-' or '.', and starting and ending with an alphanumeric character.
maxLength: 253
minLength: 1
type: string
x-kubernetes-validations:
- message: 'universeDomain must be a valid DNS subdomain:
contain no more than 253 characters, contain only lowercase
alphanumeric characters, ''-'' or ''.'', and start and
end with an alphanumeric character'
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
type: object
x-kubernetes-validations:
- message: resourceLabels may only be configured during installation
Expand Down
22 changes: 22 additions & 0 deletions ...-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,6 +2368,28 @@ spec:
be configured during installation
rule: self.all(x, x in oldSelf) && oldSelf.all(x,
x in self)
universeDomain:
description: |-
universeDomain is the GCP universe domain for the cluster, detected from
the installer credentials. Components with their own GCP credentials should
read the universe domain from those credentials, as they are the authoritative
source. This field is provided for components that do not have GCP credentials
and for general observability.

When omitted, standard public GCP (googleapis.com) is assumed.

universeDomain is an optional field that, when specified, must be non-empty and at most
253 characters. It must be a valid DNS subdomain: containing only lowercase alphanumeric
characters, '-' or '.', and starting and ending with an alphanumeric character.
maxLength: 253
minLength: 1
type: string
x-kubernetes-validations:
- message: 'universeDomain must be a valid DNS subdomain:
contain no more than 253 characters, contain only
lowercase alphanumeric characters, ''-'' or ''.'',
and start and end with an alphanumeric character'
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
type: object
x-kubernetes-validations:
- message: resourceLabels may only be configured during
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@
{
"name": "Example2"
},
{
"name": "GCPSovereignCloudInstall"
},
{
"name": "KarpenterOperator"
},
Expand Down Expand Up @@ -252,6 +249,9 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GCPSovereignCloudInstall"
},
{
"name": "GatewayAPIManagementMode"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@
{
"name": "Example2"
},
{
"name": "GCPSovereignCloudInstall"
},
{
"name": "HyperShiftOnlyDynamicResourceAllocation"
},
Expand Down Expand Up @@ -231,6 +228,9 @@
{
"name": "GCPDualStackInstall"
},
{
"name": "GCPSovereignCloudInstall"
},
{
"name": "GatewayAPIManagementMode"
},
Expand Down