Skip to content

WIP: [release-4.22] SPLAT-2865: Add vSphere multi vCenter Day 2 #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vr4manta wants to merge 9 commits into
base: release-4.22
Choose a base branch
from
Draft

WIP: [release-4.22] SPLAT-2865: Add vSphere multi vCenter Day 2 #2969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4bb935
Added vSphere Day 2 logic to CRDs
vr4manta Mar 27, 2026
d3280c7
Added vSphere Day 2 tests
vr4manta Apr 2, 2026
bfc2dc4
Modified parent logic to not check size, but only changes in existenc…
vr4manta Apr 3, 2026
7ac7f88
Added some ratcheting tests to cover change in min size of vCenters
vr4manta Apr 20, 2026
3677fd7
Updated vcenter logic to make sure no server switching occurs
vr4manta Apr 21, 2026
6fb7e2e
Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay…
vr4manta Jun 10, 2026
9ed7386
Added vSphere failure domain to vcenter check
vr4manta Jul 14, 2026
cae8bf9
Added vSphere failure domain to vcenter ratcheting tests
vr4manta Jul 23, 2026
4f1fc2a
updates after rebase
vr4manta Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: "Infrastructure"
crdName: infrastructures.config.openshift.io
featureGates:
- -AWSClusterHostedDNSInstall
- -VSphereMultiVCenterDay2
tests:
onCreate:
- name: Should be able to create a minimal Infrastructure
Expand Down Expand Up @@ -1839,3 +1840,137 @@ tests:
value: value*
type: AWS
expectedStatusError: "invalid AWS resource tag value. The string can contain only the set of alphanumeric characters, space (' '), '_', '.', '/', '=', '+', '-', ':', '@'"
- name: Should allow updating other fields with an invalid persisted vcenters array (empty) in spec
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
cloudConfig:
key: config
name: cloud-provider-config
platformSpec:
type: VSphere
vsphere:
vcenters: []
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
cloudConfig:
key: config
name: cloud-provider-config
platformSpec:
type: VSphere
vsphere:
vcenters: []
- name: Should allow keeping an invalid persisted vcenters array (empty) in spec unchanged
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
- name: Should allow updating an invalid persisted vcenters array (empty) to a valid value (1 vcenter) in spec
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters:
- server: vcenter1.example.com
port: 443
datacenters:
- DC1
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters:
- server: vcenter1.example.com
port: 443
datacenters:
- DC1
14 changes: 7 additions & 7 deletions config/v1/tests/infrastructures.config.openshift.io/VSphereMultiNetworks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -261,7 +261,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -290,7 +290,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -321,7 +321,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -349,7 +349,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -389,7 +389,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down Expand Up @@ -417,7 +417,7 @@ tests:
- datacenters:
- IBMCloud
port: 443
server: vcs8e-vc.ocp2.dev.cluster.com
server: server1.dev.cluster.com
failureDomains:
- name: generated-failure-domain
region: generated-region
Expand Down
Loading