OCPNODE-4521: Promote AdditionalStorageConfig feature gate to Default

[saschagrunert]

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@saschagrunert: This pull request references OCPNODE-4521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Promote the AdditionalStorageConfig feature gate from
TechPreviewNoUpgrade/DevPreviewNoUpgrade to the Default feature set,
making additional layer stores, image stores, and artifact stores
generally available in OpenShift 5.0.

• Enhancement: OCPNODE-4520: Update enhancement for 5.0 GA target enhancements#2022
• JIRA: https://issues.redhat.com/browse/OCPNODE-4521

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @saschagrunert! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR updates AdditionalStorageConfig so it is enabled in Default and OKD feature-gate configuration, adds the corresponding enablement in the Go feature-gate definition and defaults documentation, and moves the flag from disabled to enabled lists in four feature-gate manifests. It also removes the release.openshift.io/feature-set: CustomNoUpgrade annotation from the base ContainerRuntimeConfig CRD and deletes the feature-set-specific ContainerRuntimeConfig CRD manifests.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: promoting AdditionalStorageConfig to the Default feature set.
Description check	✅ Passed	The description matches the changeset and explains the promotion from preview to default and its purpose.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Touched files are feature-gate YAML/defs only; no Ginkgo test titles were added or changed, and the Go file change is a static feature-gate enablement list.
Test Structure And Quality	✅ Passed	No Ginkgo or test files were changed; the PR only updates feature-gate/manifests, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	PASS: the PR only updates feature-gate/config manifests and docs; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or modified; the diff only updates feature-gate configs/docs/manifests, so SNO test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only feature-gate metadata and CRD payloads changed; no deployment, controller, affinity, nodeSelector, or topology-aware scheduling logic was introduced.
Ote Binary Stdout Contract	✅ Passed	Changed Go files have no main/init/TestMain/RunSpecs blocks or stdout/logging calls; the PR only updates feature-gate and manifest data.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only updates feature-gate manifests/docs and one feature registration file; no new Ginkgo e2e tests or network/IP assumptions were added.
No-Weak-Crypto	✅ Passed	Touched files are feature-gate YAML/Go and CRD deletions; no weak-crypto, custom crypto, or secret-comparison patterns found.
Container-Privileges	✅ Passed	No changed manifest adds privileged/root, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN; patch grep found none.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only adjust feature-gate enablement/manifests; no runtime logging code or sensitive-data-bearing log statements were added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[saschagrunert]

The verify-feature-promotion check fails because there are no FeatureGate:AdditionalStorageConfig tagged test runs in Sippy yet. The e2e tests are pending merge in openshift/origin#31083 (approved, CI mostly green). Once that PR merges and accumulates sufficient test history (at least 5 tests per core platform), this check will pass.

[saschagrunert]

/retest

[yuqi-zhang]

Changes themselves looks fine, pending the tests merging and generating signal.

I see the test PR is still WIP, anything holding that up?

[everettraven]

@saschagrunert This needs a rebase and tests that pass promotion verification to progress further. Feel free to ping me when that is done and this is ready for a review.

[everettraven]

The test appears to have stopped running. I see no new runs since the 30th even though the periodics have run that should contain them. Has something changed?

The test moved from the 2of2 to the 1of2 job shard.

openshift/origin#31439 (merged Jul 28) added [Skipped:SingleReplicaTopology] to the test name to skip it on SNO. This changed the SHA-256 hash used for deterministic sharding (pkg/test/ginkgo/sharder.go), which moved the test from shard 2of2 to 1of2.

The test is still running and passing in 1of2, confirmed in today's run.

The problem is that Sippy treats the renamed test as a new test, so all run counts reset to 1. The old test name still has stale data (18/19 runs on metal/dual) that will age out of the 2-week window.

Fix: openshift/origin#31486 reverts the [Skipped:SingleReplicaTopology] tag from the Describe string and uses a programmatic skip via IsSingleNode() instead. This restores the original test name and preserves existing Sippy data.

cc @BhargaviGudi

Thanks for the additional info here - I don't think we need to change the skipping approach just for the test name change. I had missed that this would be the case, but now that I'm aware of it I think we can just combine the test runs where it makes sense (obviously omitting SNO).

With that in mind, the most recent verification would pass had there not been a test rename, so I'm happy to approve this as-is.

[everettraven]

/approve
/lgtm

Overriding promotion verification due to test renaming causing a problem, but it is the same test and when counted together correctly, the test passes promotion criteria for this feature.

/override ci/prow/verify-feature-promotion

Known hypershift integration issue that is being fixed.

/override ci/prow/verify-hypershift-integration

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-feature-promotion, ci/prow/verify-hypershift-integration

Details

In response to this:

/approve
/lgtm

Overriding promotion verification due to test renaming causing a problem, but it is the same test and when counted together correctly, the test passes promotion criteria for this feature.

/override ci/prow/verify-feature-promotion

Known hypershift integration issue that is being fixed.

/override ci/prow/verify-hypershift-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[BhargaviGudi]

/retest-required

[saschagrunert]

/verified by @BhargaviGudi

[openshift-ci-robot]

@saschagrunert: This PR has been marked as verified by @BhargaviGudi.

Details

In response to this:

/verified by @BhargaviGudi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD cfb6385 and 2 for PR HEAD 833c6e7 in total

[saschagrunert]

CI exclusion is in openshift/origin#31489

[saschagrunert]

/override ci/prow/e2e-aws-ovn-hypershift-conformance

[openshift-ci]

@saschagrunert: saschagrunert unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 7f3965b and 1 for PR HEAD 833c6e7 in total

[asahay19]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asahay19, everettraven, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/test e2e-aws-ovn-hypershift-conformance

[qodo-for-rh-openshift]

PR-Agent: could not find a component named e2e-aws-ovn-hypershift-conformance in a supported language in this PR.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 72ae442 and 0 for PR HEAD 833c6e7 in total

[openshift-merge-bot]

/hold

Revision 833c6e7 was retested 3 times: holding

[saschagrunert]

/unhold
/retest

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 72ae442 and 2 for PR HEAD 833c6e7 in total

[openshift-ci]

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	833c6e7	link	true	/test verify-hypershift-integration
ci/prow/verify-feature-promotion	833c6e7	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[saschagrunert]

@JoelSpeed this would require a need override.