Skip to content

Potential fixes for 2 code quality findings #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matteius merged 3 commits into from
Sep 15, 2026
Merged

Potential fixes for 2 code quality findings #615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78cea29
Apply suggested fix to src/web/api_handlers_audit.c from Copilot Autofix
matteius Sep 15, 2026
fb4abf0
Apply suggested fix to src/web/api_handlers_audit.c from Copilot Autofix
matteius Sep 15, 2026
9fb0fbc
Add null check for cursor in api_handlers_audit.c
matteius Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/web/api_handlers_audit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,16 @@ void handle_get_audit_events(const http_request_t *req, http_response_t *res) {

static void csv_cell(FILE *stream, const char *value) {
fputc('"', stream);
if (value && strchr("=+-@", value[0])) {
/* Keep spreadsheet applications from interpreting exported cells. */
fputc('\'', stream);
if (value) {
const char *cursor = value;
while (*cursor &&
((unsigned char)*cursor <= 0x20 || (unsigned char)*cursor == 0x7f)) {
cursor++;
}
if (*cursor && strchr("=+-@", *cursor)) {
/* Keep spreadsheet applications from interpreting exported cells. */
fputc('\'', stream);
}
}
for (const char *cursor = value ? value : ""; *cursor; cursor++) {
if (*cursor == '"') fputc('"', stream);
Expand Down Expand Up @@ -391,7 +398,11 @@ void handle_put_audit_settings(const http_request_t *req,

if (retention) {
int previous_days = AUDIT_RETENTION_DEFAULT_DAYS;
db_audit_get_retention_days(&previous_days);
if (db_audit_get_retention_days(&previous_days) != 0) {
cJSON_Delete(body);
http_response_set_json_error(res, 500, "Failed to load audit settings");
goto unlock_and_return;
}
if (db_audit_set_retention_days(retention_days) != 0) {
cJSON_Delete(body);
http_response_set_json_error(res, 500, "Failed to save audit settings");
Expand Down
Loading