fix: leftover ExtractFd stoi abort on oversized fd:// - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
ExtractFd digit-checks fd:// then calls std::stoi. A long digit string still throws std::out_of_range and aborts. Parse with strtol and reject ERANGE / out-of-int / non-digits. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemSoundVibrator::ExtractFdalready rejects afd://suffix that is not all digits, then still callsstd::stoi. A digit-only string that does not fit inint(2147483648,9999999999999999999) throwsstd::out_of_rangeand aborts the process.Parse with
strtoland reject empty / non-digits /ERANGE/ out-of-int/ negative. Same leftover class as other OH property/stoiguards.Test plan
g++ -fsanitize=address,undefined): legacystoithrows on oversizedfd://;strtolpath returns-1and accepts0/3/INT_MAX.Signed-off-by: Tony Coder 407243179@qq.com