fix: leftover packing-tool CLI stoi - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
packing-tool parses untrusted CLI integers (version-code, compress-level, atomic-service size limits, general/version-normalize params) with std::stoi. Overflow throws; partial/junk tokens can still be accepted when callers skip digit prechecks. Parse with std::from_chars via ParsePackingInt32 so valid in-range values stay unchanged and overflow/partial/empty/junk is rejected and logged. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
app_packing_toolparses untrusted CLI integers withstd::stoi:Utils::IsPositiveInteger(version-code / API version validation)--compress-level--atomic-service-entry-size-limit/--atomic-service-non-entry-size-limitversion-normalize/general-normalizeCLI version and API paramsstd::stoithrows on overflow and can accept partial tokens when callers skip digit prechecks. Empty / junk input is not rejected uniformly.Fix
Add
ParsePackingInt32(std::from_chars) inpacking_tool/frameworks/include/parse_packing_int.h.+prefix, hex, and floats."0"/"5"/"2048"/"4194304"/ leading zeros /INT_MAX/INT_MIN).Test
Host + ASan/UBSan verification of
ParsePackingInt32(kept out of this PR):0/1/5/9/2048/4194304/ leading zeros /INT_MAX/INT_MIN/-11abc, spaces,+, hex, float, newlineAll cases passed with
-fsanitize=address,undefined.Signed-off-by: Tony Coder 407243179@qq.com