Repository navigation
Apache canonical host - #678
Merged
Merged
Conversation
…only on successful responses `Header set` applies only to responses Apache doesn't generate itself, so redirects and errors from mod_rewrite and access control lacked the header at the origin. Cloudflare's HSTS setting currently adds it at the edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB7xnMp5MnC8no9eDkui8n
…DMembers auto to add them The certificate's names are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB7xnMp5MnC8no9eDkui8n
RobHooper
reviewed
Oct 7, 2026
…wn virtual host, instead of from WordPress The aliases move from the port 443 virtual host to their own, so requests to the server name don't evaluate the redirect. Port 80 keeps the aliases for MDRequireHttps and ACME challenges. Like port 80, the redirects are logged to other_vhosts_access.log, not to the site's logs. Closes #677 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB7xnMp5MnC8no9eDkui8n
…chived repository Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB7xnMp5MnC8no9eDkui8n
…e access logs, as from the server-wide log Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB7xnMp5MnC8no9eDkui8n
jpmckinney
force-pushed
the
apache-canonical-host
branch
from
October 7, 2026 17:20
2c32e3c to
341eeb5
Compare
Member
Author
|
Thank you for the review! The config would now render as: <MDomain www.open-contracting.org open-contracting.org>
MDRequireHttps permanent
</MDomain>
<VirtualHost *:80>
ServerName www.open-contracting.org
ServerAlias open-contracting.org
</VirtualHost>
<VirtualHost *:443>
ServerName open-contracting.org
SSLEngine on
Protocols h2 http/1.1 acme-tls/1
Header always set Strict-Transport-Security "max-age=31536000; includeSubDomains; preload"
RewriteEngine on
RewriteRule ^ https://www.open-contracting.org%{REQUEST_URI} [R=301,L]
</VirtualHost>
<VirtualHost *:443>
ServerName www.open-contracting.org
SSLEngine on
Protocols h2 http/1.1 acme-tls/1
ErrorLog /var/log/apache2/corporate/error.log
CustomLog /var/log/apache2/corporate/access.log vhost_combined env=!dontlog
Include /etc/apache2/sites-available/corporate.conf.include
</VirtualHost> |
RobHooper
approved these changes
Oct 8, 2026
Member
Author
|
Noting that this extends env=!dontlog into these logs, so I think we have no way to know if AppBeat, Pingdom, or /server-status checks ever start behaving badly/unexpectedly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #677