Destination list: the station name is never squeezed out by the count chip - #67
Merged
Merged
Conversation
… chip The from/to card was one flex row where the count chip and the arrow stub never shrink and the name may shrink to nothing: at a 1100px window every name got 6px. The name now sits on its own line above the chips, the shape the Ideas rows use, and a chip wider than the column wraps its words.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7/10, high
Problem
Browsing every destination from a station gives a list of cards with no station name on them. In a 1100px wide window each card reads
24 this day · 285 this month 1 h 56and nothing else, so the list cannot be used to pick a place.The card is one flex row in
groupCardEl: the name, then the chips, then the 74px arrow stub. The chips and the stub never shrink, and the name is the one item that may, down to nothing. At that window the list column is 350px and the chip alone is 201px, so every name gets 6px, "Lyon" included. Any window that leaves the column near its 340px minimum does the same, in every locale whose chip runs as long as the English one.Fix
The name sits on its own line above the chips, in the stacked shape the Ideas and discovery rows already use, so it reads in full at every width and the chips wrap under it. A chip wider than the column wraps its words, as it already does under 520px, rather than running under the arrow stub. The card keeps its 58px height at 1600px, where the chip and the duration still share one line, grows to 94px at 1100px, and at 390px shows the longest name in the list, "Valence Tgv Auvergne Rhone Alpes", whole.