Repository navigation
Modernize tooling and improve browser/Electron RPC integration - #57
Merged
Merged
Conversation
oe
marked this pull request as ready for review
October 3, 2026 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC calls could retain timers and unresolved promises after failure/destruction, confuse business progress with heartbeat data, or arrive before a peer's handlers were ready. Calls now clean up deterministically and support optional local cancellation/deadlines; explicit readiness probes prevent startup races without retrying business operations.
Browser/Electron integration:
createRpcClient<Api>checks method names/parameters and infers asynchronous results without a proxy layer or new wire protocol.READY_METHOD/waitForPeerprovide an explicit ready endpoint with bounded, cancellable probing.true; accidentally async validators fail closed without unhandled rejections.Tooling pins pnpm 12.8.1, TypeScript 7.0.2, Vite 8.3.2 and Vitest 5.0.3. TypeScript emits declarations directly; Oxlint replaces the obsolete lint stack. Published library JavaScript preserves ES2018 syntax, checked after packing; developers' modern Node requirement does not become a consumer runtime requirement. Node import/require share classes and shared hubs; browser bundlers retain ESM. Legacy filenames, extensionless distribution imports and the UMD global remain available.
Correctness/performance:
Validation:
Performance evidence:
Release boundaries:
UNKNOWNondestroy(), and reserved localsignal/requestTimeoutfields. Packages remain unbumped/unpublished.heartbeatTimeout: 0retains its 500ms fallback.Upgrade review and benchmark methodology.