Repository navigation
Conversation
The ci workflow written at bootstrap already runs scripts/task check on every pull request and on main, with cargo and pnpm caching. What the item lacked was proof: a canary pull request carrying a clippy-only warning failed CI and was blocked from merging, and cached runs finish in under a minute against a five-minute bound. Refs: 0013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cairn item 0013 asks for CI that formats, lints and tests every pull request. The
ciworkflow from bootstrap already did that, but nothing proved it: nobody had shown that a clippy warning fails a PR, or measured a cached run.Approach
No workflow change. This PR records the evidence in the item, ticks the three criteria and closes 0013.
scripts/task checkand nothing that duplicates it. Thecheckjob runs./scripts/task checkand nothing else.staticrunsscripts/task build:static, a release musl build thatcheckdoesn't do.requiredcollects the job results.liam'sversion_lineto usereturn format!(...);. Locally, rustc gave 0 warnings and clippy failed onclippy::needless_return. CI run 37085900711 on1feb7cbfailedcheckwith exit 101, sorequiredfailed and the PR's merge state wasBLOCKED. Branch protection onmainrequiresrequired(strict). test: clippy canary for 0013 (do not merge) #6 is closed and its branch deleted.checkjob took 36 s and the whole run 46 s.Budget impact
None. CI wall time is unchanged: about 46 s per cached PR run.
Look at this sceptically
--no-verify. I created it on the server through the GitHub contents API instead. No local gate was skipped, but the canary branch never went through the hooks. That is the point of the canary, and it's still worth knowing.Checks
scripts/task check: green locally.cairn check: ok, 97 items, 0 warnings.