-
Notifications
You must be signed in to change notification settings - Fork 0
chore: make the review-ready label actually trigger a review #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,11 +157,19 @@ any mention of what prompted it downstream. | |
|
|
||
| ## Asking for a Code Review | ||
|
|
||
| CodeRabbit reviews this repository **on request, never automatically**. A pull | ||
| request is reviewed when it carries the `review-ready` label, or when someone | ||
| comments `@coderabbitai review` on it. Nothing else triggers one, and an | ||
| unlabelled pull request gets no comment at all. What it reviews against is in | ||
| `.coderabbit.yaml` and in the documents that file points at — this one included. | ||
| CodeRabbit reviews **only the pull requests that ask for it**. A pull request is | ||
| reviewed when it carries the `review-ready` label, or when someone comments | ||
| `@coderabbitai review` on it. Nothing else triggers one, and an unlabelled pull | ||
| request gets no comment at all. What it reviews against is in `.coderabbit.yaml` | ||
|
Comment on lines
+162
to
+163
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: sed -n '154,176p' CLAUDE.md
rg -n '`@coderabbitai` review|auto_review|labels' .coderabbit.yaml CLAUDE.mdRepository: odal-node/dpp-engine Length of output: 2670 🌐 Web query:
💡 Result: <search_synthesis> <source_evidence> Citations:
🏁 Script executed: sed -n '145,205p' CLAUDE.md
printf '\n--- .coderabbit.yaml auto-review section ---\n'
sed -n '28,75p' .coderabbit.yamlRepository: odal-node/dpp-engine Length of output: 6826 State the automatic-review scope precisely. The 🤖 Prompt for AI Agents |
||
| and in the documents that file points at — this one included. | ||
|
|
||
| 🚨 **A review reads the pull request as it stood when the review ran, and | ||
| nothing re-reads it.** `auto_incremental_review` is off, so a push after a | ||
| review — a rebase, a conflict resolution, a branch folded in, a fix for a | ||
| finding — is merged unread unless someone asks again. **If a push changes what | ||
| the review looked at, comment `@coderabbitai review`.** Nothing enforces this, | ||
| and five pull requests were merged on 2026-09-16 carrying rebases and conflict | ||
| resolutions that no review had seen. | ||
|
|
||
| **Apply the label when the branch is genuinely finished, and not before.** | ||
| Finished means all of: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: odal-node/dpp-engine
Length of output: 5403
🌐 Web query:
CodeRabbit auto review configuration labels enabled false documentation💡 Result:
<search_synthesis>
In CodeRabbit, setting reviews.auto_review.enabled to false disables automatic reviews globally [1][2]. However, you can use the reviews.auto_review.labels configuration to create an opt-in workflow even when automatic reviews are disabled [1][2]. When enabled is false, adding a positive label (e.g., "review-ready") to a pull request will trigger an automatic review [1][2]. Negative-only labels (such as those starting with "!", like "!wip") continue to act as exclusion filters and will not trigger a review on their own [1][2]. Example configuration for label-based opt-in: reviews: auto_review: enabled: false labels: ["review-ready"] In this configuration, only pull requests labeled "review-ready" will be reviewed automatically [1][2]. If you wish to disable reviews entirely for a specific pull request, you can add "
@coderabbitaiignore" to the pull request description [3][4].</search_synthesis>
<source_evidence>
Citations:
Describe
enabled: trueas an operational workaround.CodeRabbit documents that a positive
labelsmatch triggers reviews even whenreviews.auto_review.enabledisfalse. Keepenabled: trueif the observed skipped reviews andpre_merge_checksbehavior require it, but describe it as a service workaround rather than the documented requirement for label-based opt-in. (docs.coderabbit.ai)🤖 Prompt for AI Agents