Skip to content

docs(skills): name the objectui upload packages after the providers fold - #30683

Merged
os-zhuang merged 1 commit into
mainfrom
claude/project-thread-nbwyvd
Nov 6, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
claude/project-thread-nbwyvd

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread
Fixes #30559

Clause-②: no
Metadata-protocol: none

维护者速读

  • 改了什么:objectui 技能的 project-setup 指南里两处上传说明(provider 列表与决策矩阵)不再指向已退役的 @object-ui/providers,改为点名 @object-ui/fields、@object-ui/data-objectstack 与 @object-ui/types。
  • 为什么改:PR refactor(ui)!: fold the providers upload context into fields and data-objectstack, retire @object-ui/providers #30550 把上传能力并入 fields 并退役 providers 包;客户 agent 按旧指南会装一个不再发版、也没有上传上下文的依赖。
  • 风险与回滚:纯文档,不动代码与契约;回滚即 revert 本 PR。为付令牌棘轮,删了故障排查里两条只适用于 monorepo 的提示(Turbo 缓存一节与「下游包要先 build dist」一行)。
  • 先看:skills/objectui/guides/project-setup.md 的 L249 段与决策矩阵上传行;其次故障排查节的两处删除。
  • 两分钟验证:git grep -n "@object-ui/providers" -- skills/ 预期零命中;node scripts/check-skills-token-ratchet.mjs 预期该文件 2726/2727 绿。
  • 需要你做的:批准并合并(skills/** 为 Tier H,人合)。

What changes

  • skills/objectui/guides/project-setup.md, provider-stack list: UploadProvider / useUpload now come from @object-ui/fields; the ObjectStack storage adapter createObjectStackUploadAdapter from @object-ui/data-objectstack; the UploadAdapter / UploadOptions / UploadResult contract from @object-ui/types, re-exported by @object-ui/fields.
  • Decision matrix, uploads row: + @object-ui/fields (UploadProvider), @object-ui/data-objectstack (adapter).
  • Token payment (same-file deletion, no ceiling move): the troubleshooting section drops the ### Turbo cache issues block and the Run pnpm build — downstream packages need built dist/ directories line. Both are advice for working inside the ObjectUI monorepo, not for a third-party app that consumes published packages; nothing else in the guide or the objectui skill points to them (grep -i turbo over the guide, SKILL.md and README.md: 0 hits after the edit).
  • One root changeset, '@objectstack/skills': patch.

Every name was read off origin/main b77c160, not off the card: ui/packages/fields/src/index.tsx L5485 (UploadProvider, useUpload) and L5486 (re-export of UploadAdapter, UploadOptions, UploadResult from @object-ui/types); ui/packages/data-objectstack/src/index.ts L8024 (createObjectStackUploadAdapter); ui/packages/types/src/index.ts L498 (the contract). ui/packages/providers no longer exists on main. All three packages are published (no private flag). No other skills/** line names @object-ui/providers.

Tests

Docs-only diff; no test pins changed behaviour, so no ablation.

Skills size readings (head 67b7dec)
  • Edited file: skills/objectui/guides/project-setup.md 349 → 346 lines, 2718 → 2726 tokens (ceiling 2727, headroom 1).
  • Whole package, sum of every SKILL.md: 4534 → 4534 lines (no SKILL.md touched).
  • Bundle total (whole shipped tree, check-skills-token-ratchet): 226234 → 226242 tokens.

Acceptance notes

  • The dispatch asked that nothing else in the guide change; the two troubleshooting deletions are the token-ratchet payment. The seat accepted the Turbo block; the dist/ line was needed for the last 3 tokens and is the same monorepo-only class.

Verification

Local subset at head 67b7dec: node scripts/pm/dispatch-gates.mjs --ran reconciles 44 derived families: 43 run with exit 0, 1 NOT MEASURED. pnpm lint exit 0 (outside the derivation).

Gate readings
  • node scripts/check-skills-token-ratchet.mjs: exit 0, "57 authored bundle file(s) within their ceilings".
  • pnpm --dir ui exec vitest run scripts/: exit 0, Test Files 170 passed / 2 skipped, Tests 4970 passed / 2 skipped.
  • pnpm check:dual-build-cjs-loads: NOT MEASURED, reason: PREREQUISITE NOT MET (exit 3), the gate reads every package's built dist/ and this worktree built only the closures the derived gates need; CI builds first.
  • Every other derived family: exit 0.

Generated by Claude Code

The project-setup guide sent a third-party app to @object-ui/providers for
UploadProvider/useUpload. That package is retired; the provider-stack list and
the decision matrix now name @object-ui/fields (UploadProvider/useUpload),
@object-ui/data-objectstack (createObjectStackUploadAdapter) and
@object-ui/types (the UploadAdapter contract, re-exported by fields).

The token ratchet is paid by dropping two monorepo-only troubleshooting tips.

Claude-Session: https://claude.ai/code/session_016WV4d1CgLtPgbu4RrVtPDQ
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface labels Nov 5, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

Contract-review-claim: session_016WV4d1mkgEris4MHHLjtnk · head 67b7dec · 2026-11-05T22:22Z

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 67b7dec4d7757598c4a9a9e7b6793c95233b1144
Local-runs: none
Scope: skills/objectui/guides/project-setup.md (hits) + .changeset/30559-objectui-upload-guide-packages.md + cited ui/packages/fields/src/index.tsx, ui/packages/fields/package.json, ui/packages/data-objectstack/src/index.ts, ui/packages/data-objectstack/src/upload-adapter.ts, ui/packages/data-objectstack/package.json, ui/packages/types/src/index.ts, ui/packages/types/package.json, scripts/check-skills-token-ratchet.mjs (read on origin/main b77c160)

① Derived judgments

  • Accept set / public surface: unchanged. One governed rule-text file and one changeset; no ui/**, packages/**, schema, exports or .d.ts.
  • "UploadProvider / useUpload (@object-ui/fields)" (guide L249): true, ui/packages/fields/src/index.tsx:5485; @object-ui/fields is published (no private).
  • "createObjectStackUploadAdapter (@object-ui/data-objectstack)" (L250-251): true, ui/packages/data-objectstack/src/index.ts:8024; upload-adapter.ts:12-13,18 implements the @object-ui/types contract.
  • "UploadAdapter / UploadOptions / UploadResult from @object-ui/types, re-exported by fields" (L251-252): true, ui/packages/types/src/index.ts:498 and ui/packages/fields/src/index.tsx:5486.
  • Decision-matrix row (L309): consistent with the bullet; @object-ui/fields is already a minimum dependency (L24, L37).
  • @object-ui/providers is gone from origin/main; git grep "@object-ui/providers" -- skills/ on the head is empty (the card's pin).
  • Token ratchet ceiling for the file stays 2727 (scripts/check-skills-token-ratchet.mjs:1044, untouched).

② Semver level

'@objectstack/skills': patch, correct for a docs-only correction of a governed guide. Changeset carries Clause-②: no and Metadata-protocol: none, matching the PR body; no Skills-docs: line owed. Check Changeset: success.

③ Boundary flags

  • PR author objectstack-fleet[bot].
  • Deviation (two troubleshooting tips deleted to pay the ratchet): accepted. The guide's reader is a third-party app consuming published packages (L1-3, L24-25, L33-37, L225). ### Turbo cache issues and "Run pnpm build — downstream packages need built dist/" are ObjectUI-monorepo advice; those rules keep their home in AGENTS.md:63-64,367 and CONTRIBUTING.md:63,94-95; no skills/** file points at the deleted text.
  • open_questions: none. File surface matches the order exactly.
  • Check-runs at head (read 2026-11-05T22:24Z): no red; 11 still in progress. All-green is the landing-time check.

④ Design judgment

skills/objectui/guides/project-setup.md: the rewritten lines teach imports that resolve on main, each attributed to the package whose exports publishes it; "is ObjectStack's" leaves room for a third-party UploadAdapter. The card's scenario (agent loads the skill, installs live packages, no dead dependency) holds. The remaining "Module not found" bullets read coherently.

  • must-fix: none.
  • should-fix: none blocking. Optional later: L341 "Run pnpm install to ensure workspace links are resolved" is the same monorepo-flavoured class; a later token payment could rewrite it.

Implemented-by: claude/project-thread-nbwyvd
Reviewed-by: session_016WV4d1mkgEris4MHHLjtnk

VERDICT: PASS

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

维护者速读

  • 改了什么:objectui 技能的 project-setup 指南里两处上传说明(provider 列表与决策矩阵)不再指向已退役的 @object-ui/providers,改为点名 @object-ui/fields(UploadProvider/useUpload)、@object-ui/data-objectstack(ObjectStack 上传适配器)与 @object-ui/types(适配器契约)。
  • 为什么改:PR refactor(ui)!: fold the providers upload context into fields and data-objectstack, retire @object-ui/providers #30550 把上传能力并入 fields 并退役 providers 包;客户 agent 按旧指南会装一个不再发版、也没有上传上下文的依赖。
  • 风险与回滚:纯技能文档,不动代码与契约;回滚即 revert 本 PR。为付令牌棘轮删了故障排查里两条只适用于 ObjectUI monorepo 的提示,这两条规则在 AGENTS.md/CONTRIBUTING.md 仍有出处。
  • 先看:skills/objectui/guides/project-setup.md 上传那段(约 L249)与决策矩阵上传行。
  • 两分钟验证:git grep -n "@object-ui/providers" -- skills/ 预期零命中;node scripts/check-skills-token-ratchet.mjs 预期该文件 2726/2727 绿。
  • 需要你做的:批准并合并(skills/** 为 Tier H)。契约复核 PASS 评论 6671144014,Head-sha 67b7dec4d7757598c4a9a9e7b6793c95233b1144。
  • 席位意见:可合。

席位核对 — ACCEPT · head 67b7dec

  • 形态:2 文件 +18/−8(指南一份 + 根 changeset '@objectstack/skills': patch)。check-governed-merges --pr 30683:governed skills/** ×1(Tier H),26 行 ≤ 3000。Fixes #30559,draft,目标 main,作者 objectstack-fleet[bot]。
  • 契约:Clause-② no,Metadata-protocol none,与认领 6670612452 一致;无 Skills-docs: 行欠。
  • 前提实测:dev 报告 6671063790;三个包名逐个在 origin/main 的入口导出核过(复核记录 ①);@object-ui/providers 在技能树零命中。
  • 门禁 check-runs:head 上 56 个,48 success,8 skipped,0 红;mergeable_state clean。
  • 接受的偏差:为付棘轮删两条 monorepo 专用提示(Turbo 缓存一节、「先 build dist」一行),读者是第三方应用作者,用不上;卡写「指南其余不变」,席位接受这一处付账。
  • 范围外去向:无。复核的可选建议(L341 pnpm install 一句同属 monorepo 口吻)只记于复核记录,不立卡。
  • 落地条款:Tier H,等 governed 审批人批准;批准后席位经中继 pr_ready + automerge_enable,合并后核 skills: the objectui project-setup guide still sends a third-party app to @object-ui/providers for uploads, a package PR #30550 retires #30559 已关、摘 pm:dispatched。

@objectstack-fleet objectstack-fleet Bot added the pm:awaiting-merge PR only: landing waits on the maintainer's own review and merge (SKILL.md 复核 ②); never on an issue label Nov 5, 2026
@os-zhuang
os-zhuang marked this pull request as ready for review November 6, 2026 00:58
@os-zhuang
os-zhuang enabled auto-merge November 6, 2026 00:58
@os-zhuang
os-zhuang added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 6b2129f Nov 6, 2026
62 checks passed
@os-zhuang
os-zhuang deleted the claude/project-thread-nbwyvd branch November 6, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation pm:awaiting-merge PR only: landing waits on the maintainer's own review and merge (SKILL.md 复核 ②); never on an issue size/s tooling Fix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skills: the objectui project-setup guide still sends a third-party app to @object-ui/providers for uploads, a package PR #30550 retires

2 participants