Repository navigation
docs(authentication): say Setup shows the address the server judges before an allowed IP ranges save - #30582
Merged
Conversation
…efore an allowed IP ranges save The "Saving, clearing and lockout recovery" list now names the note under the Allowed IP ranges field: the address the server judges for the request, read from GET /api/v1/auth/admin/client-address (platform administrators only), whether forwarded headers counted, and the no-address case. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Utp6CZhiLoN3MZGp7ZnqCg
Contributor
Author
|
domain:server#2 · os-bill · session_01Utp6Cbvcmv8YWFhFJwzjKL 维护者速读
席位核对 — ACCEPT · domain:server#2 · head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Bill · project thread
domain:server#2 · os-bill · session_01Utp6CZhiLoN3MZGp7ZnqCg
Fixes #30570
Clause-②: no — docs only
Metadata-protocol: none
维护者速读
authentication.mdx的「Saving, clearing and lockout recovery」加一条,写明 Setup → Authentication 在「允许的 IP 段」字段下显示服务器判定的本次请求地址,数据来自GET /api/v1/auth/admin/client-address(仅平台管理员),并说明三种提示各指什么。main上控制台的英文文案。回滚即撤本 PR。content/docs/permissions/authentication.mdx新增的「Setup shows your address before you save.」一条。ui/packages/i18n/src/locales/en.ts的clientAddressDirect/clientAddressViaProxy/clientAddressUnknown三句,预期文档描述与三句一一对应、无多说。What changes
One new bullet in Saving, clearing and lockout recovery (chosen over the
allowed_ip_rangestable row: the row already defers the save behaviour to that section, and the note is about what you see before a save, so it sits next to the save rule it previews):Checked against
mainatdb04e5ce, which carries PR #30540 (b6f4c0e8b7):ui/apps/console/src/pages/settings/SettingsView.tsxclientAddressNote: three states,clientAddress === null→clientAddressUnknown,trustProxy→clientAddressViaProxy, elseclientAddressDirect; drawn only on theauthnamespace underallowed_ip_ranges.ui/packages/i18n/src/locales/en.ts:clientAddressDirect("…This server does not trust proxy headers, so behind a proxy this is the proxy's address."),clientAddressViaProxy("…read from the forwarded headers of the proxy this server trusts…"),clientAddressUnknown("The server cannot establish your address, so a non-empty list cannot be saved from here.").packages/plugins/plugin-auth/src/client-address-read.ts:200 { success: true, data: { clientAddress, trustProxy } },clientAddressnullwhen no address can be established,gateAdmin(platform admin),Cache-Control: no-store.Not said, because the console does not do it: no note is drawn when the read fails (non-admin, older server); the page does not claim one. No other sentence on the page is made false by the read: the
allowed_ip_rangesrow and the refusal bullet stay true as written.Changeset: none. Followed AGENTS.md Post-Task Checklist step 3 and os-dev's rule:
skip-changesetis for a diff that publishes nothing from any released package;content/docs/**is in no package'sfiles[](the repo's own negative control inscripts/check-changeset-no-major.mjsnamescontent/docs/**as publishing nothing). Labelskip-changesetrides this create.Verification
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack content/docs/permissions/authentication.mdx: 45 commands. All 45 exit 0 at head115efa0e; five first exited 3 (prerequisite:@objectstack/spec,@objectstack/lint,@objectstack/formula,@objectstack/client-reactnot built) and were re-run green afterturbo run buildof those closures.--ranreconciliation: 45 derived, 45 run, 0 NOT-MEASURED, 0 UNRUN.Build Docsjob and the type-check lanesdispatch-gateslists as CI-only.!, no narrowing arm).🤖 Generated with Claude Code
https://claude.ai/code/session_01Utp6CZhiLoN3MZGp7ZnqCg
Generated by Claude Code