Repository navigation
refactor(plugin-chatbot)!: retire eight zero-consumer entry exports - #30576
Merged
Merged
Conversation
The plugin-chatbot entry stops publishing useFloatingChatbot with its FloatingChatbotState, FloatingChatbotActions and FloatingChatbotContextValue types, ChatMessageProps, toRuntimeToolInvocation, unwrapToolResult and summarizeChatError. Each name had zero hits outside the package (workspace and hotcrm); every module stays. Claude-Session: https://claude.ai/code/session_01L6bhgTj6bWX8Rq5fpUGNv7 Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:ui#6 · os-sales · session_01L6bhgUR8Nu4M7tbtgES7q2 维护者速读
席位核对 — ACCEPT · head 59fd4bf
|
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sales · project thread
Part of #25921. The umbrella stays open; this is the second barrel batch of claim 6660204183 (amendment 6661865751, seat
domain:ui#6). The first batch was #30541.Clause-②: no (narrowing)
Metadata-protocol: none
维护者速读
@object-ui/plugin-chatbot的包入口不再导出 8 个名字:浮动聊天的上下文钩子useFloatingChatbot及其三个状态/动作/上下文类型、内部消息行的ChatMessageProps、一个工具调用转换函数、两个工具结果展示辅助函数。模块全部保留,行为不变。@object-ui/*包不受影响。回滚即 revert 本 PR。ui/packages/plugin-chatbot/src/index.tsx(四处导出改写)、.changeset/25921-plugin-chatbot-zero-consumer-exports.md(迁移说明)。git grep -l -w -e useFloatingChatbot -e unwrapToolResult -e summarizeChatError -e toRuntimeToolInvocation -- ':!ui/packages/plugin-chatbot' ':!**/CHANGELOG.md'应只命中本 PR 的 changeset。What changes
ui/packages/plugin-chatbot/src/index.tsx:useFloatingChatbotand the typesFloatingChatbotState,FloatingChatbotActions,FloatingChatbotContextValue(FloatingChatbotProviderandFloatingChatbotProviderPropsstay);ChatMessageProps, the props of the internalChatMessageItemrow, becomes a local interface;toRuntimeToolInvocationleaves the adapter export list (toRuntimeMessages,authoredToRuntimeMessage,toRuntimeRole,toRuntimeTimestamp,toRuntimeToolStatestay; the README teaches the last three andtoRuntimeMessages);unwrapToolResultandsummarizeChatErrorleave the display-helper export (humanizeToolNamestays)..changeset/25921-plugin-chatbot-zero-consumer-exports.md: patch level,!title, BREAKING paragraph, FROM/TO lines for every retired name, ADR-0087 markernot-required (runtime-export-retired …)naming all eight operands.FloatingChatbotTriggerandFloatingChatbotPanelread the hook from its module,toRuntimeMessagescallstoRuntimeToolInvocation, andChatbotEnhancedcalls the two display helpers.Tests
Census on
origin/main75bbebb, re-read at this head on top of 48b3ae6 (same counts), with batch 1's method: the entry's 102 export names from the TypeScript checker; per namegit grep -o -w -Foutsideui/packages/plugin-chatbot, minus**/CHANGELOG.md, lockfiles and.changeset/**; the package README; keep rule 3 (a kept export's declared type reaches it, by a checker walk); hotcrm6961ab1. 44 names had zero outside hits: 2 are README-taught, 29 are reached by a kept export's declared type, 8 are retired here, and 5 are kept for a reason:useFloatingChatbot,FloatingChatbotState,FloatingChatbotActions,FloatingChatbotContextValueChatMessagePropstoRuntimeToolInvocationunwrapToolResult,summarizeChatErrorTypingIndicatorTypingIndicatorPropsis named in aplugin-dashboardcomment (prose counts), and the component and its props go togetheremitAiUsageRefresh,AGENT_ALIAS_GROUPS./coresubpath entry, outside this claim's surfaceauthoredToRuntimeMessage,toRuntimeTimestampChatbotEnhanced51,humanizeToolName10,FloatingChatbot8,toRuntimeMessages3,FloatingChatbotProvider1; hotcrmListView7Readings on the batch commit 94dc257f (cut from 75bbebb), before the move onto this branch:
turbo run type-checkfor@object-ui/plugin-chatbot,@object-ui/app-shell,@object-ui/consolewith their^buildclosure: 76 of 76 tasks;vitest run packages/plugin-chatbot/: Test Files 95 passed (95), Tests 880 passed (880); one lock VERDICT command-exit 0.vitest run scripts/(ui): Test Files 170 passed, 2 skipped (172); Tests 4985 passed, 2 skipped (4987); VERDICT command-exit 0..d.ts: a temporary app-shell probe importing the eight retired names plusFloatingChatbotProvider,FloatingChatbotProviderProps,toRuntimeMessages,humanizeToolNameandTypingIndicatorgave exactly eight errors (TS2305/TS2724 … has no exported member), one per retired name; the controls resolved. Probe deleted;git statusclean.check:readme-exports:0 fabricated, 0 stale omission(s); exit 1 only on the knownpackages/cliunbuilt prerequisite.check-platform-checklist --changed-from origin/main: exit 0, 0 anchored files.pnpm --filter @objectstack/dogfood testunder the lock): Test Files 420 passed, 3 skipped (423); Tests 3496 passed, 36 skipped (3532); VERDICT command-exit 0.The re-run on this branch's head 59fd4bf (the cherry-pick onto 48b3ae6) is recorded in the os-dev-report on #25921.
Acceptance notes
emitAiUsageRefreshandAGENT_ALIAS_GROUPShave zero outside hits on both entries; retiring them means editingsrc/core.ts(the./coresubpath), which a later batch can take.claude/project-thread-h719zv(batch 1's branch, restarted frommainafter refactor(plugin-dashboard, plugin-list)!: retire eight zero-consumer entry exports #30541 merged), notclaude/issue-25921-*.Verification
Derived gates and the head re-run are in the os-dev-report on #25921; CI check-runs on this PR are the record for every family CI runs.
Generated by Claude Code