Skip to content

ci(scaffold-e2e): build the skills-boundary expected set from the whole curated skills/ catalog #26285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 3 commits into from
Oct 26, 2026
Merged

ci(scaffold-e2e): build the skills-boundary expected set from the whole curated skills/ catalog #26285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c974eef
ci(scaffold-e2e): build the skills-boundary expected set from the who…
claude Oct 26, 2026
411e29a
ci(scaffold-e2e): keep the curated-catalog loop's exit status 0 when …
claude Oct 26, 2026
a9585ae
ci(scaffold-e2e): state which assertion an internal skill in skills/ …
claude Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/scaffold-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,23 @@ jobs:
# 2. Interactive `skills add …/framework` (no --all) relies on
# metadata.internal hiding — assert repo-root discovery surfaces
# exactly the curated set and nothing internal.
# The curated catalog is every skills/<dir>/ holding a SKILL.md — the
# same tree @objectstack/skills ships whole (packages/skills/scripts/
# sync-catalog.mjs), read the same way as the package-catalog step
# below. ⛔ Never a name glob or an allow-list here: a skill added to
# skills/ would red this step until a governed edit of this file.
# An internal skill placed in skills/ still fails: the CLI hides
# metadata.internal skills, so the installed set (assertion 1) or the
# listed count (assertion 2) falls short of the directory set.
run: |
cd "$RUNNER_TEMP"
node "$GITHUB_WORKSPACE/packages/create-objectstack/bin/create-objectstack.js" skills-probe --skip-install --skip-skills
cd skills-probe
expected=$(cd "$GITHUB_WORKSPACE/skills" && ls -d objectstack-*/ | tr -d '/' | sort)
expected=$(for d in "$GITHUB_WORKSPACE"/skills/*/; do if [ -f "${d}SKILL.md" ]; then basename "$d"; fi; done | sort)
if [ -z "$expected" ]; then
echo "::error::skills/ holds no <skill>/SKILL.md — the curated catalog this step compares against is empty"
exit 1
fi
expected_count=$(echo "$expected" | wc -l | tr -d ' ')

npx -y skills add "$GITHUB_WORKSPACE/skills" --all --copy
Expand Down
Loading