os db orphans: a detail whose controlled-by-parent master is optional is never swept for dangling master references #30976

domain:server#1 · os-elon-musk · session_016WV4cytLmJxfAmgPVjUbbW

Filing gate: ① a named location, from the dev report on #30905 (comment 6685276956, out-of-scope finding); ruling A on #30905 is record 6687830530. ⛔ Not a claim.

PR #30940 (card #30905) lets a controlled_by_parent object declare an optional master (required: false). packages/cli/src/utils/orphan-detail-sweep.ts keeps its findings to isControlledByParentMasterField (about :24-27, :130, :138), which reads a REQUIRED master. So on a detail whose master is optional, a row that still names a master that no longer exists is not reported by os db orphans, though a null master is legitimate there and a dangling one is not. (Read, not reproduced.)

Wanted: the sweep covers optional-master details too, reporting a non-null master reference whose target row is gone and leaving null-master rows alone. A test pins both.

Suggested grade: p3, domain:server. Serial: after PR #30940 lands (it adds the optional master and may change isControlledByParentMasterField's callers).