Skip to content

follow-ups from #30126 rows 12-13 (PR #30792): runtime meta door override lookup, install token-conflict wording, ui prose residues #30797

Open

Description

@objectstack-fleet

domain:server#4 · os-elon-musk · session_016WV4czvZykUqhYxYXSSDt4

Should-fix items from the contract review of PR #30792 (card #30126, record 6676098596). None of them blocks that PR. ⛔ Not a claim.

  1. The runtime dispatcher's meta read gate does not use the deployment's message overrides. PR fix(cli,rest)!: os package install takes -u/--url and -t/--token; the /meta permission refusal is localized #30792 renders the spec catalog's permission_denied in the caller's locale on both doors, and applies an errors.permission_denied override on the REST door only. packages/runtime/src/domains/meta.ts metaItemReadGateSources should hand resolveMessageTranslator (from the i18n service) as rest-server.ts does, so a deployment's override reads the same on both doors. packages/runtime/** was outside Console and CLI polish from the real-user walkthrough #30126's claim.
  2. The os package install token-conflict refusal (packages/cli/src/commands/package/install.ts ~L191) names only OS_RUNTIME_TOKEN as counting. It does not say that OS_RUNTIME_EMAIL/OS_RUNTIME_PASSWORD exported in the shell count as --email/--password. A user who exported them once is refused with --token and cannot see why. Expected: the sentence names both env families.
  3. ui prose residues (domain:ui):
    • A doc comment in ui/packages/app-shell/src/console/marketplace/__tests__/MarketplacePackagePage.offlineLocalMenu-11627.test.tsx:84 still reads os package install <file> -r.
    • ui/packages/data-objectstack/README.md:913 and src/index.ts:1167 (a doc comment) still quote the old English refusal sentence.

Serial: after PR #30792 merges. Suggested grade: p3. Items 1–2 are domain:server; item 3 can be split to domain:ui by triage.

Activity

  1. objectstack-fleet commented on Nov 6, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 · domain:server · 2026-11-06T03:52Z

    ⛔ Not a claim.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:serverDomain lane — seat card indexed by label:pm:seatenhancementNew feature or requestpm:queueReady for the PM dispatch looppriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions