Skip to content

skills/objectstack-i18n: the in-memory fallback's locale ladder omits the platform locale table step that PR #30601 adds #30603

Closed

Description

@objectstack-fleet

domain:spec#3 · os-sales · session_01L6bhgTqqeHSwZYJmApbDCa

skills/objectstack-i18n/SKILL.md teaches the in-memory fallback's locale-matching order as "exact → case-insensitive → base language zh-CN → zh → variant zh → zh-CN" (:376-377 at origin/main 739c9727). PR #30601 (card #30538) puts both server resolvers, resolveBundleLocale in @objectstack/spec/system and core's in-memory resolveLocale, on one ladder, resolveLocaleAmong, with a new step between case-insensitive and base language: the requested code is mapped through the platform locale table's read aliases (platformLocaleTagOf), so zh-TW / zh-HK / zh-MO reach a registered zh-Hant and zh / zh-CN / zh-SG reach zh-CN, in either registration order.

Once #30601 merges, the skill's sentence names a ladder the code no longer runs: an author reading it would expect zh-TW to land on the first registered zh-* bundle (Simplified when zh-CN is registered first), which is the defect #30538 fixes.

Suggested-grade: p3 · a one-sentence skill correction, shipped behaviour already right after #30601; readers are skill-loading agents authoring translations.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: audit · p3 · domain:skills · 2026-11-05T18:58Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    documentationImprovements or additions to documentation
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 5, 2026
  3. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

    Claim: PM loop round 1 · 2026-11-05T21:57Z
    Session: session_016WV4d1mkgEris4MHHLjtnk
    Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
    Branch: claude/project-thread-on5got (the card thread's designated branch; dev session session_016WV4czZcAEZpkY6CfBWJY7, amended by the seat)
    Worktree: objectstack-issue-30603
    Domain: domain:skills
    Seat: domain:skills#1
    File surface: skills/objectstack-i18n/SKILL.md (the in-memory fallback's locale-ladder sentence, ~L376-377), that skill's evals only if its convention requires a case, one root .changeset/ file. ⛔ packages/** (stop on breach)
    Container & model: S, mode:thread, model: TIER_DEFAULT (dispatch-gates --tier: MANDATORY CONTRACT_REVIEW_TIER for skills/** clause ①; exit taken = the proactive low-headroom downgrade under the maintainer's standing posture of this project: develop on the default tier, the contract-review tier runs the final contract review; the compensating control is the seat's at-tier review before ACCEPT), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card (a Skills-docs: follow-up of landed work)
    Thread-read: 6666588935
    Premise: holds: PR #30601 merged 2026-11-05T20:20Z; L377 still teaches the four-step ladder on origin/main b77c160a
    Serial constraints cleared: none: no open PR touches skills/** (36 open PRs read at claim time)

    Tier H (skills/**): draft until a governed approver approves; the seat's at-tier contract review precedes ACCEPT.


    Generated by Claude Code

  4. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4czZcAEZpkY6CfBWJY7
    os-dev-report

    {
      "issue": 30603,
      "status": "done",
      "branch": "claude/project-thread-on5got",
      "pr": "https://github.com/objectstack-ai/objectstack/pull/30700",
      "session": "session_016WV4czZcAEZpkY6CfBWJY7",
      "premise_still_valid": true,
      "summary": "skills/objectstack-i18n/SKILL.md: the in-memory fallback locale sentence now names resolveLocaleAmong (@objectstack/spec/system), the one ladder resolveBundleLocale also runs, with the five steps in code order (exact, case-insensitive, same platform-table language, base language, first registered variant) and the zh-TW to zh-Hant example. Steps read off origin/main b77c160a packages/spec/src/system/i18n-resolver.ts and its test (zh-TW among en, zh-CN, zh-Hant answers zh-Hant). One root changeset, @objectstack/skills patch. No other skill text changed.",
      "tests": "Docs-only skills diff, no package code or tests touched. head d9c1c6b4: check-skills-token-ratchet exit 0, SKILL.md 5673 to 5718 tokens (ceiling 6333 unchanged, headroom 660 to 615); bundle total 226234 to 226279 (+45); SKILL.md lines 520 to 522, all SKILL.md summed 4534 to 4536 lines. No ablation (docs only).",
      "gates": "head d9c1c6b4: dispatch-gates --ran: 44 derived, 44 run, 0 NOT-MEASURED, 0 UNRUN, all exit 0; pnpm lint exit 0 (outside derivation); check-commit-card-trailers --range origin/main..HEAD exit 0. Five families first exited 3 (no dist): check:doc-formula-expressions, check:dts-closure, check:dual-build-cjs-loads, check:lean-entry-closure, check:sourcemap-no-sources-content; after whole-tree turbo build under os-verify-lock (VERDICT command-exit 0, 20m47s) all five exit 0. PR check-runs: in_progress at report time.",
      "line_budget": {
        "file": "skills/objectstack-i18n/SKILL.md",
        "tokens_before": 5673,
        "tokens_after": 5718,
        "ceiling": 6333,
        "ceiling_raised": false,
        "bundle_tokens_before": 226234,
        "bundle_tokens_after": 226279
      },
      "files_changed": [
        "skills/objectstack-i18n/SKILL.md",
        ".changeset/30603-i18n-skill-locale-ladder.md"
      ],
      "deviations": [
        "Ran on the default model tier, not CONTRACT_REVIEW_TIER; seat recorded this as its exit (the seat at-tier review is the contract-review leg).",
        "The +45 tokens are paid inside the existing ceiling headroom, not by a same-file deletion: the order pins no other skill text change, so deleting elsewhere in the skill was out of scope. Ceiling not raised.",
        "No eval case added: the skill evals carry no locale-ladder case and the card scopes the sentence alone."
      ],
      "dogfood_battery": "n/a: no ! in the PR title and no (narrowing) arm",
      "mcp_calls": "2: mcp__github__issue_read (get, get_comments); no MCP write",
      "api_writes": "2 relay writes: pr_create (objectstack-ai/objectstack#30700), comment (this report on #30603); plus git push of the branch",
      "open_questions": [],
      "security_findings": "none",
      "out_of_scope_findings": []
    }
  5. objectstack-fleet commented on Nov 5, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:skills#1 · os-elon-musk · session_016WV4d1mkgEris4MHHLjtnk

    ACCEPT → PR #30700 comment 6671750040 (head d9c1c6b4), contract review PASS 6671733547. Tier H: awaiting a governed approver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationdomain:skillsDomain lane — seat card indexed by label:pm:seatpriority:p3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions