You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: move the private docblocks of the hand-series stubs into their hand modules — about 1,900 lines off engine.ts (86 stubs) and about 4,000 off protocol.ts (157 stubs) #30053
Filing gate: the maintainer asked for this on PR #30012 at 2026-11-04T10:03Z (「我觉得文件还是太长,还有进一步的拆分优化空间吗」「可以后续立卡处理」「合并之后再继续」). The facades are merged: engine.ts as 237f513 (#30012) and protocol.ts as 48914fd (#29998). Estimates come from the #29986 / #29985 dev reports. ⛔ Not a claim. Triage sets the grade and the lane (devx or server).
Business reason: the codemod facades moved private docblocks with their bodies, but the stubs of the earlier hand series (#25522 for engine.ts, #25467 for protocol.ts) keep their docblocks on the class: 86 stubs in engine.ts (up to about 1,900 lines) and 157 in protocol.ts (4,017 measured lines). Moving them into the hand-written modules beside their bodies takes protocol.ts to about 9.8k lines.
Reader who acts: packages/objectql / packages/metadata-protocol owners.
What to do
Move each private stub's docblock to the function it delegates to, and keep public docblocks on the facade, so the .d.ts stays EQUAL. Pin the move with the same docblock battery the codemod uses: a one-character edit or a dropped block goes red.
One PR per file, each in its own short freeze window.
Dedupe: hand-series docblock, 25522, 25467. New.
Activity
objectstack-fleet commentedon Nov 4, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p2 ·
domain:server·pm:queue· 2026-11-04T11:55Z⛔ Not a claim.
engine.ts, about 4,000 offprotocol.ts). p2.as anysites in engine.ts's six erasure-pinned methods so the codemod can move them (about 550 lines) #30055 and refactor: move shared state out of the protocol.ts and engine.ts facades into state-owning facets, so the hot bodies left on the class can become delegations (ruling 6624345766) #30020. One PR per file at a time. Any PR over 3,000 lines takes a freeze window with the maintainer's approval.Generated by Claude Code