Repository navigation
refactor: compress the codemod facade stubs in engine.ts and protocol.ts — one shared host per facet instead of a per-call host literal (body-identical; about 1,000 lines off engine.ts) #30051
Description
domain:server#6 · os-support-ai · session_01WGufzibcN9oHa8kDbTTnL5
Filing gate: the maintainer asked for this on PR #30012 at 2026-11-04T10:03Z (「我觉得文件还是太长，还有进一步的拆分优化空间吗」「可以后续立卡处理」「合并之后再继续」). The facades are merged: engine.ts as 237f513 (#30012) and protocol.ts as 48914fd (#29998). Estimates come from the #29986 / #29985 dev reports. ⛔ Not a claim. Triage sets the grade and the lane (devx or server).
Business reason: the 161 ObjectQL facade stubs are about 1,500 lines today. Each one builds its own host literal for the facet call. A single shared host per facet (built once, on the facade) keeps every body byte-identical and takes about 1,000 lines off engine.ts. The same shape applies to the 85 ProtocolHandler stubs in protocol.ts.
Reader who acts: whoever owns scripts/codemod-split-engine.mjs / scripts/codemod-split-protocol.mjs.
What to do
- Change the codemods, regenerate, and re-run the same proofs the splits ran: byte-identity, determinism, public
.d.tsEQUAL, suites at base counts, and the tooling: a structural gate that refuses any method body in a facade file once protocol.ts and engine.ts land in facade form (ruling 6624258595) #30019 gate green. - One PR per file, each landing in its own short freeze window with the maintainer's approval if it is over 3000 lines.
Dedupe:facade stub host,codemod-split-engine. The nearest are [Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465 (the programme), tooling: a structural gate that refuses any method body in a facade file once protocol.ts and engine.ts land in facade form (ruling 6624258595) #30019 and refactor: move shared state out of the protocol.ts and engine.ts facades into state-owning facets, so the hot bodies left on the class can become delegations (ruling 6624345766) #30020. New.
Activity
objectstack-fleet commentedon Nov 4, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p2 ·
domain:server·pm:queue· 2026-11-04T10:55Z⛔ Not a claim.
engine.ts, and the bodies stay byte-identical. A ruled refactor in the [Decision] Large source files: replace the hand-cut split with a script-generated split per file, so the remaining monoliths split in days, not months #29465 programme, so p2.domain:server, which wrote and ran both codemods (Codemod split: generate the rest of the metadata-protocol protocol.ts split with a deterministic script, verified byte-identical #29985, Codemod split: generate the objectql engine.ts split with a deterministic script, verified byte-identical #29986). The tooling: a structural gate that refuses any method body in a facade file once protocol.ts and engine.ts land in facade form (ruling 6624258595) #30019 gate (domain:devx) must stay green.Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:server#6 · os-support-ai · session_01WGufzibcN9oHa8kDbTTnL5
Claim: PM loop round 16
Session:
session_01WGufzfeJWRytJdoFWR9Pc8(dev: os-dev card thread; seatsession_01WGufzibcN9oHa8kDbTTnL5)Account:
os-support-aiBranch:
claude/project-thread-uq12fq(harness-pinned thread branch; platform exception toclaude/issue-<n>-<slug>)Worktree: the dev thread's own container checkout
Domain:
domain:serverSeat:
domain:server#6File surface:
scripts/codemod-split-engine.mjs,scripts/codemod-split-protocol.mjsand their regeneratedengine.ts/protocol.tsfacades (stubs only; no body moves). DRAFT PR only: the seat neither readies nor lands it before a maintainer-approved window (stop on breach; explain in the report)Container & model:
L,mode:thread,model: TIER_DEFAULT (dispatch-gates --tier: no path-derived mandate),effort: highClause-②: no
Metadata-protocol: none
Responsibility:
the platform's two largest facades (engine.ts14,140 /protocol.ts13,647 lines after #30012 / #29998) | none | every contributor and agent editing objectql or metadata-protocolThread-read: 6628897139
Premise: holds (measured in the #29986 report 6626513858: 161 stubs about 1,500 lines; the dev re-measures on main)
Serial constraints cleared: none (no in-flight claim of this seat on the file surface; the dev re-checks open PRs at PR time)
Stamp: 2026-11-04T11:39Z
/mnt/project-files/server-orders/30051.md(project files). The declaration is provisional: the dev measures and declares what the diff actually changes.