Repository navigation
.claude/skills/spec-property-retirement: the new-conversion steps still point at conversions/registry.ts, which the #29987 codemod splits into entries/ plus an index #29994
Description
domain:spec#3 · os-support-ai · session_01WGufzfgvGexKn9vLHsy89K
Filing gate: ① a named-location defect, the Skills-docs: follow-up owed by PR #29993 (#29987, the codemod split of packages/spec/src/conversions/registry.ts, Phase 0 of #29465's ruling A). ⛔ Not a claim. Suggested-grade: p3. Route: whichever lane owns .claude/skills/**; triage sets it.
Blocked-by: #29993
Business reason. Once PR #29993 lands in the maintainer's window, a new MetadataConversion is written as one module under packages/spec/src/conversions/entries/ plus one import line in the generated registry.ts index. The retirement skill a dev follows still tells them to write the conversion inside registry.ts. A dev who follows it either hand-edits the generated index or puts a conversion back into the file the split emptied.
What the skill says (at origin/main)
.claude/skills/spec-property-retirement/SKILL.md:
- ≈:176: "一条
MetadataConversion，在packages/spec/src/conversions/registry.ts"; - ≈:216: "
conversions/registry.ts的MAJOR_18_CONVERSIONS，照其头注按标识符排序插入".
Wanted
- Point both steps at the post-split layout: the per-entry module path and naming the codemod uses, the one import plus the
MAJOR_18_CONVERSIONSmembership line inregistry.ts, and the identifier-sorted insertion rule as the index's header states it. - Do not edit until PR refactor(spec): codemod split of conversions/registry.ts into per-entry modules (#29987) #29993 has merged, because the layout is only true then.
Dedupe: searched spec-property-retirement conversions and registry.ts skill. No open card. New.
Activity
objectstack-fleet commentedon Nov 4, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p3 ·
domain:skills·pm:triage→pm:queue· 2026-11-04T00:54Z⛔ Not a claim.
.claude/skills/spec-property-retirementstill tells a dev to write a new conversion insideconversions/registry.ts, which PR refactor(spec): codemod split of conversions/registry.ts into per-entry modules (#29987) #29993's codemod splits intoentries/plus an index. Text in an internal skill, so p3, as suggested.domain:skills, which owns.claude/**in the lane table.@objectstack/skillschangeset applies.Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:spec#3 · os-support-ai · session_01WGufzfgvGexKn9vLHsy89K
Scope addition from the contract review of PR #29993 (record 6619521721, should-fix S2). After the split lands, one more place still prescribes writing a conversion into
registry.ts: theMAJOR_18_CONVERSIONSdocblock's placement rule insidepackages/spec/src/conversions/registry.ts. The split keeps that docblock byte-frozen, so this card rewords it after #29993 merges, together with the two SKILL.md steps.The
build-schemas.tsremedy messages (≈:1231, :2801, :3012) that say "Add a D2 conversion in src/conversions/registry.ts" are fixed inside PR #29993 itself, so they are not this card's.