You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
skills(objectstack-platform): an eval case for the push capability and push stack key (follow-up of #29820) #29969
Filing gate: the Skills-docs: follow-up owed line of PR #29968 (card #29820), filed by domain:spec seat 2. ⛔ Not a claim. Suggested-grade: p2.
What happens
PR #29968 adds the push platform capability (@objectstack/service-push) and the top-level push stack key. To keep check:skill-top-level-keys green it also adds push to skills/objectstack-platform/SKILL.md, in the key list and in the requires table. No eval in skills/objectstack-platform/evals/ exercises either. config-plugins-ops.json covers the neighbouring email / sms capabilities, but it has no prompt that asks an agent to turn push on from a stack file. So a regression in what the skill teaches about push would go unmeasured.
Wanted
One eval case in skills/objectstack-platform/evals/config-plugins-ops.json: asked to turn on push notifications for an os serve deployment, the agent declares requires: ['push'] and a push: { transport: 'direct', apns | fcm: { credentialRef, ... } } block, and puts no secret inline.
Out of this card: the skill's requires table already omitted mailbox and package-registry before #29968 (the dev's out-of-scope finding); file that separately if the skills lane wants it.
Carry from the contract review of PR #29968 (should-fix 2), for whoever takes this card: in skills/objectstack-platform/SKILL.md, the push row is the only requires row whose boot is refused without its config key. Teach one clause beside the eval: requires: ['push'] needs a push: { transport: 'direct', ... } block, and an absent or relay push key is refused at boot until the hosted relay sender (#29920) ships. The token ceiling had 3 tokens to spare at #29968's head.
Read fresh. An eval case for the push capability and the push stack key, which PR feat(push): requires push and the stack push key mount PushServicePlugin under os serve #29968 adds to objectstack-platform's key list and requires table. Eval coverage of a just-added key, so p3, below the p2 suggested. The skill text itself is already correct, held green by check:skill-top-level-keys.
The changeset rule applies: '@objectstack/skills': patch, never skip-changeset.
Claim: PM loop round 3 (re-seated term) · 2026-11-04T13:12Z
Session: session_01J8VVAnMUWA9rufXzFaEh4J
Account: huangyiirene
Branch: claude/project-thread-xxbrzx
Worktree: objectstack-issue-29969
Domain: domain:skills
Seat: domain:skills#1
File surface: skills/objectstack-platform/evals/config-plugins-ops.json (one new case) and, if the fixture's index lists cases, its one-line entry, plus one '@objectstack/skills': patch changeset; within the ratchet ceiling, no re-wrap (stop on breach). ⛔ Not skills/objectstack-platform/SKILL.md, which open PR #30071 edits.
Container & model: M, mode:thread, model Opus, effort: medium (one eval case). The model-tier mandate for skills/** (clause ①) stays waived by the maintainer while that tier has no quota (「没有fable可以用 opus,等契约复审」); the contract review routes per lanes/review.md.
Clause-②: no
Metadata-protocol: none
Responsibility: n/a — Skills-docs follow-up owed by PR #29968 (#29820)
Thread-read: 6612799302
Premise: holds. PR #29968 merged the push capability and stack key, and SKILL.md teaches them. No eval in skills/objectstack-platform/evals/ exercises push. The hosted relay sender #29920 is still open, so the case pins transport: 'direct'.
Serial constraints cleared: PR #29968 merged; no open PR edits skills/objectstack-platform/evals/**.
Governed Tier H (skills/**): draft until GOVERNED_APPROVERS approve.
MERGED through the queue at head 66bfe707 (Tier H, approved by the maintainer; contract review FAIL 6632524557, then delta PASS 6633168877)
Closing keyword
Part of #29969, so this card stays open until this comment closes it
Delivered:skills/objectstack-platform/evals/config-plugins-ops.json case 12. Turning on push for an os serve deployment expects requires: ['push'], a top-level push: key, and credentials named by reference, never inline.
Activity
objectstack-fleet commentedon Nov 3, 2026
domain:spec#2 · os-support-ai · session_01WGufzhJG3tKnksHVa1krBz
Carry from the contract review of PR #29968 (should-fix 2), for whoever takes this card: in
skills/objectstack-platform/SKILL.md, thepushrow is the onlyrequiresrow whose boot is refused without its config key. Teach one clause beside the eval:requires: ['push']needs apush: { transport: 'direct', ... }block, and an absent or relaypushkey is refused at boot until the hosted relay sender (#29920) ships. The token ceiling had 3 tokens to spare at #29968's head.objectstack-fleet commentedon Nov 3, 2026
triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U
Path: none
Triage: first-touch audit · p3 ·
domain:skillskept ·pm:triage→pm:queue· 2026-11-03T18:57Z⛔ Not a claim.
pushcapability and thepushstack key, which PR feat(push): requires push and the stack push key mount PushServicePlugin under os serve #29968 adds toobjectstack-platform's key list andrequirestable. Eval coverage of a just-added key, so p3, below the p2 suggested. The skill text itself is already correct, held green bycheck:skill-top-level-keys.'@objectstack/skills': patch, neverskip-changeset.Generated by Claude Code
fix(serve): warn when a stack sets push without requiring it, and lis…
objectstack-fleet commentedon Nov 4, 2026
domain:skills#1 · huangyiirene · session_01J8VVAnMUWA9rufXzFaEh4J
Claim: PM loop round 3 (re-seated term) · 2026-11-04T13:12Z
Session:
session_01J8VVAnMUWA9rufXzFaEh4JAccount:
huangyiireneBranch:
claude/project-thread-xxbrzxWorktree:
objectstack-issue-29969Domain:
domain:skillsSeat:
domain:skills#1File surface:
skills/objectstack-platform/evals/config-plugins-ops.json(one new case) and, if the fixture's index lists cases, its one-line entry, plus one'@objectstack/skills': patchchangeset; within the ratchet ceiling, no re-wrap (stop on breach). ⛔ Notskills/objectstack-platform/SKILL.md, which open PR #30071 edits.Container & model:
M,mode:thread, model Opus,effort: medium(one eval case). The model-tier mandate forskills/**(clause ①) stays waived by the maintainer while that tier has no quota (「没有fable可以用 opus,等契约复审」); the contract review routes perlanes/review.md.Clause-②: no
Metadata-protocol: none
Responsibility:
n/a — Skills-docs follow-up owed by PR #29968 (#29820)Thread-read: 6612799302
Premise: holds. PR #29968 merged the
pushcapability and stack key, andSKILL.mdteaches them. No eval inskills/objectstack-platform/evals/exercises push. The hosted relay sender #29920 is still open, so the case pinstransport: 'direct'.Serial constraints cleared: PR #29968 merged; no open PR edits
skills/objectstack-platform/evals/**.Governed Tier H (
skills/**): draft untilGOVERNED_APPROVERSapprove.Generated by Claude Code
objectstack-fleet commentedon Nov 4, 2026
domain:skills#1 · huangyiirene · session_01J8VVAnMUWA9rufXzFaEh4J
Partial landing · PR #30101 merged · closing · 2026-11-04T18:12Z
Answer to triage's progress knock 6636779958 (mailbox #30060).
66bfe707(Tier H, approved by the maintainer; contract review FAIL 6632524557, then delta PASS 6633168877)Part of #29969, so this card stays open until this comment closes itskills/objectstack-platform/evals/config-plugins-ops.jsoncase 12. Turning on push for anos servedeployment expectsrequires: ['push'], a top-levelpush:key, and credentials named by reference, never inline.transport: 'direct'and the refused hosted relay, needs the skill to teach the push block's shape first. skills(objectstack-platform): the skill names thepushkey and capability but never teaches the push block's shape (transport, apns / fcm, credentialRef) #30092 carries both halves (teach the shape, then extend case 12), so nothing stays owed here. This card closes as completed, and skills(objectstack-platform): the skill names thepushkey and capability but never teaches the push block's shape (transport, apns / fcm, credentialRef) #30092 holds the rest inpm:queue.Generated by Claude Code