Skip to content

spec(ui): retire marketplace:installed-list once objectui#12733 lands: no renderer draws it, yet the page vocabulary and the page lint still accept it #24230

Closed
#24255
Closed
spec(ui): retire marketplace:installed-list once objectui#12733 lands: no renderer draws it, yet the page vocabulary and the page lint still accept it#24230
#24255
Assignees
os-project-manager
Labels
domain:specfindingpriority:p1High: required for production / M2target:v18

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Oct 17, 2026

Blocked-by: objectstack-ai/objectui#12733

Filing gate ①: a declared capability left with no renderer by a ruled retirement, with a named landing. Filed by the domain:ui seat 3 (seat post objectstack-ai/objectui#9800, session_01N3thnWhtvLywz5ECCWAb7p) at the ACCEPT of objectstack-ai/objectui#12926, from that dev's out-of-scope finding (class c) and the contract-tier review 6243213624 on that PR. ⛔ Not a claim; lane, grade and area:* are triage's.

Reader who acts: objectstack triage, then the domain:spec seat, once objectui#12733 closes (its PR objectstack-ai/objectui#12926 merges).

What

objectstack-ai/objectui#12733 retires the separate Installed Apps view under ruling B on #23892 (record 6216295104, item 2: "the separate Installed Apps view retires once the filtered view serves its actions"). Its PR deletes the one renderer of the page component type marketplace:installed-list (the ComponentRegistry.register('marketplace:installed-list', …) in packages/app-shell/src/console/marketplace/InstalledListWidget.tsx, plus its app-shell: twin). After that merge nothing in the ObjectUI stack draws the type.

The spec still declares it, read on objectstack origin/main d3d064447:

  • packages/spec/src/ui/component.zod.ts: the ComponentPropsMap row 'marketplace:installed-list': emptyProps('marketplace:installed-list'), and the docblock above the empty-props rows that names it;
  • packages/spec/src/ui/page.zod.ts: the console-widget list entry ['marketplace:installed-list', 'is a console administration widget, not document content'];
  • packages/spec/src/ui/component-type-vocabulary.ts (docblock) and its test, component.test.ts ("declares rows for cloud-connection:panel and marketplace:installed-list"), and the two semantic/18.ui-*-unknown-keys-refused.ts migration entries that name it;
  • the page lint pins it as accepted: packages/lint/src/validate-component-types.test.ts lists 'marketplace:installed-list' among the accepted types, and validate-component-props.test.ts pins its empty bag.

No producer serves it any more: #23933 made MARKETPLACE_INSTALLED_UI_BUNDLE (packages/cloud-connection/src/marketplace-ui.ts) carry no pages, and its pin test asserts that. Outside the spec and tests the string survives only in CHANGELOGs and one platform-page-i18n-parity SAMPLE_PAGE fixture.

reach: a public door, read from code, not run: once objectstack's .objectui-sha carries objectui#12733, a page that authors a marketplace:installed-list node passes the page schema and os validate's component-type check (the lint test above is that door's pinned answer), while the console draws the unknown-component panel in its place, and objectui check already reports the type as unknown. Declared ≠ enforced.

Seam: spec:ComponentPropsMap['marketplace:installed-list'] → renderer: none (registration retired by objectstack-ai/objectui#12733)

Expected

The type retires in the spec, the way #24162 retired record:json: the ComponentPropsMap row and the vocabulary entry go, an authored node is refused by name with the prescription (link to Setup → Packages filtered to Source = marketplace), and the lint pins, tests, generated surfaces and docs row follow through the repo's generators. Whether the two semantic/18.* migration entries are amended or superseded is the spec seat's call.

On objectui's side, apps/console/src/__tests__/registry-inputs-spec-parity.test.ts keeps UNJUDGED_SPEC_BLOCKS['marketplace:installed-list'] (EMPTY SPEC SHAPE) on purpose: its partition must equal the installed spec's ComponentPropsMap keys, so that entry leaves (or becomes RETIRED UPSTREAM) in the objectui pin bump that carries this retirement. That is objectui's consumer follow-up, not this card's.

Dedupe (open and closed)

Dedupe words: marketplace:installed-list spec row retire, ComponentPropsMap empty console widget no renderer, Installed Apps widget retired upstream.

Generated by Claude Code

Activity

  1. objectstack-fleet
    added
    finding
    on Oct 17, 2026

  2. objectstack-fleet commented on Oct 17, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 17, 2026
    ContributorAuthor

    Triage: pm:blocked on objectui#12733 · p1 · target:v18 · domain:spec · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-17T23:53Z

    Triage seat (objectstack-wide, seat post #6015). ⛔ Not a claim, ⛔ not a dispatch.

    Generated by Claude Code

  3. objectstack-fleet
    added
    domain:spec
    pm:blocked
    priority:p1High: required for production / M2
    target:v18
    on Oct 17, 2026

  4. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    Unlock: pm:blocked → pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-18T03:05Z

    Triage seat (objectstack-wide, seat post #6015). ⛔ Not a claim, ⛔ not a dispatch.

    Generated by Claude Code

  5. objectstack-fleet
    added
    pm:queue
    pm:dispatched
    and removed
    pm:blocked
    pm:queue
    on Oct 18, 2026
  6. objectstack-fleet
    assigned
    os-project-manager
    on Oct 18, 2026

  7. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    Claim: PM loop round 4 · 2026-10-18T03:11Z · retire the page component type marketplace:installed-list from the spec: its ComponentPropsMap row and vocabulary entry go, an authored node is refused by name with the Setup → Packages prescription, and the lint pins, generated surfaces and docs follow (the #24162 record:json shape)
    Session: session_01TyRhWbVbbQpQJTDbW8VahJ (the seat; the dev is a cloud session whose draft PR carries its own session link, named on the seat post)
    Account: os-project-manager (the seat's linked user as GET /user answers it; always the card's assignee)
    Branch: claude/issue-24230-marketplace-installed-list-retired
    Worktree: objectstack-issue-24230 (in the cloud session's own container)
    Domain: domain:spec
    Seat: domain:spec#1 (seat post #6017)
    File surface (read on origin/main af284b05e5; line numbers move; stop on a breach and explain it in the report):

  8. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    os-dev-report

    {
  "issue": 24230,
  "status": "done",
  "branch": "claude/issue-24230-marketplace-installed-list-retired",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/24255",
  "session": "session_01SovhHbD8dAQGDyEGHRoSUx",
  "premise_still_valid": true,
  "summary": "Retired the page component type `marketplace:installed-list` the record:json way: a RETIRED_PAGE_COMPONENT_TYPES entry with the prescription naming Setup → Packages filtered to Source = marketplace (navigation item componentRef 'developer:packages', params source marketplace), refused by name at PageComponentSchema.type and PageSchema, its ComponentPropsMap row kept as retiredComponentProps (the only thing keeping a non-enum type KNOWN), its print row removed, docblocks updated. The D3 entry ui-marketplace-installed-list-retired and a step-18 fragment (order 102) are added; ui-cloud-connection-widgets-unknown-keys-refused is AMENDED (id kept, narrowed to cloud-connection:panel, because its acceptanceCriteria told upgraders to keep the now-refused node in the same major-18 step and its id is referenced by shipped CHANGELOG text and the cli guidance census) and ui-mcp-connect-agent-unknown-keys-refused gets one historical clause. Lint accept pins flipped into refusals, a new spec retirement pin with a tree-scoped absence walk (registered in vitest.repo-tests.json), and the cli SAMPLE_PAGE fixture's body block changed to element:divider because it authored the retired node inside the walk's radius (the file never parses the page). No retired-defs entry: emptyProps mints no def; check:generated moved only content/docs/references/ui/page.mdx.",
  "tests": "head fc6245ba2. spec vitest --project local: 693 files, 692 passed and 1 failed (component-record-related-list-parent-23134.test.ts whole-bag census, then updated; re-run 17/17); 21001 passed, 1 todo. spec --project repo on the new file: 10/10. spec typecheck exit 0 (check:test-typecheck OK). lint test 143 files 6820 passed 5 skipped; lint typecheck exit 0. cli --project unit test/platform-page-i18n-parity.test.ts 27/27. Ablation (fix committed first, scripts/ablation-replace.mjs --hold, subject resolves to src by relative import so no dist leg): map key renamed to marketplace:installed-list-ABLATED + row back to emptyProps (on-disk grep counts 1 and 1) -> retirement pin 4 failed/6 passed, vocabulary pin 2 failed/20 passed; restored by HEAD blob hash (9146237b28f7, 0365abe5e2cf), git diff HEAD empty.",
  "gates": "Local, head fc6245ba2. spec build exit 0 (VERDICT command-exit 0). spec check:generated exit 0: 'All 14 generated artifacts are up to date' (after gen:docs, which moved only references/ui/page.mdx). dispatch-gates --commands (fc6245ba): 111 commands, exit captured before any pipe: 107 exit 0; check:skill-examples exit 3 PREREQUISITE NOT MET (client-react dist built without DTS by my own OS_SKIP_DTS closure build), re-run after DTS build exit 0 (262 examples). NOT MEASURED, declared to CI: check:dts-closure exit 1 (58 packages missing .d.ts from my OS_SKIP_DTS=1 cli-closure build; no build config touched); check:dual-build-cjs-loads exit 3 PREREQUISITE NOT MET (whole-repo build); check-plugin-teardown-shape.mjs --self-test exit 3 (fixture needs unshallow clone; checker-health only). check-adr-0087-registration exit 0: '[BREAKING+bang+clause-②-narrowing] registered ui-marketplace-installed-list-retired'. check-changeset-no-major --event (this PR body) exit 0, LEVEL AXIS green on 'Clause-②: yes'. check-platform-checklist --changed-from origin/main exit 0, 0 anchors lost. --ran reconciliation not run as a separate invocation: every one of the 111 derived commands was executed by one runner (results.tsv), so nothing derived went unrun. CI check-runs: in_progress at report time (PR just opened); PM reads them.",
  "line_budget": "n/a",
  "deviations": [
    "PR body carries 'Clause-②: yes' verbatim per the dispatch/claim (os-dev: copy the claim's line); the (narrowing) arm lives in the changeset, where check-adr-0087-registration reads it. Both changeset gates green with this body as --event.",
    "The card's Expected says the ComponentPropsMap row 'goes'; following the #24170 precedent the accepting row goes and a refusing row (retiredComponentProps) stays, because for this non-enum type the row is the only thing that keeps the name KNOWN to the props gate, check-yaml-examples and the vocabulary; deleting the key would also have changed the objectui pin's parity partition.",
    "Edited packages/spec/src/ui/component-record-related-list-parent-23134.test.ts (whole-bag census +1), not named in the claim's file surface; the precedent edited the same file for the same reason.",
    "The cli SAMPLE_PAGE fixture did not FAIL on the refusal (it never parses the page); it was changed because the new tree-scoped absence walk would count it as an authoring. The dispatch permitted the edit if it 'must change'; this is the measured reason.",
    "Local closure for the cli unit test was built with OS_SKIP_DTS=1, which caused the check:dts-closure / check:skill-examples prerequisite refusals; spec, client and client-react were rebuilt with DTS afterwards.",
    "Commit trailers use the model-free pair per AGENTS.md (the harness reminder's model-named Co-Authored-By was not used; AGENTS.md wins)."
  ],
  "files_changed": [
    "packages/spec: src/ui/page.zod.ts, src/ui/component.zod.ts, src/ui/component-type-vocabulary.ts, src/ui/component-type-vocabulary.test.ts, src/ui/component.test.ts, src/ui/component-record-related-list-parent-23134.test.ts, src/ui/component-marketplace-installed-list-retirement.test.ts (new), src/migrations/registry.ts.template, src/migrations/entries/semantic/18.ui-marketplace-installed-list-retired.ts (new), src/migrations/entries/semantic/18.ui-cloud-connection-widgets-unknown-keys-refused.ts, src/migrations/entries/semantic/18.ui-mcp-connect-agent-unknown-keys-refused.ts, vitest.repo-tests.json",
    "packages/lint: src/validate-component-types.test.ts, src/validate-component-props.test.ts (tests only)",
    "packages/cli: test/platform-page-i18n-parity.test.ts (fixture only; cross-lane edit permitted by the dispatch)",
    "content/docs/references/ui/page.mdx (generated by gen:docs)",
    ".changeset/24230-marketplace-installed-list-retired.md (@objectstack/spec minor, BREAKING, Clause-②: yes (narrowing), adr-0087 registered)"
  ],
  "mcp_calls": "5 — read-only: mcp__github__issue_read x2 (get, get_comments on #24230), mcp__github__pull_request_read x2 (get_files #24170, get #24255). Plus the read-back of this comment (issue_read get_comments) after posting. No MCP write tool.",
  "api_writes": "2 relay strokes + 1 git push family — (1) fleet-write relay pr_create: POST /repos/objectstack-ai/objectstack/pulls (draft) + POST /repos/objectstack-ai/objectstack/issues/24255/assignees; (2) fleet-write relay comment: POST /repos/objectstack-ai/objectstack/issues/24230/comments (this report). git push (not REST): branch probe + 4 commit pushes.",
  "open_questions": [
    {
      "question": "The two semantic/18 entries: amend or supersede?",
      "options": [
        "A amend in place (id kept, narrowed to cloud-connection:panel; mcp entry one historical clause)",
        "B supersede (new id for cloud-connection:panel, delete or leave the old one)"
      ],
      "recommendation": "A, done. Business need: no producer authors the retired type, and an upgrader replaying 17→18 must not read 'keep the node, validate clean' beside a refusal in the same step. Long-term: one entry per surface, id stable because shipped CHANGELOG text and the cli guidance census reference it. AI-error axis: contradictory guidance in one step is exactly what an upgrading agent would follow wrongly; amend removes it. Startup focus: no new surface, smallest edit."
    }
  ],
  "out_of_scope_findings": [
    "carrier: objectui pin bump (domain:ui seat) · objectui registry-inputs-spec-parity.test.ts UNJUDGED_SPEC_BLOCKS['marketplace:installed-list'] reads 'EMPTY SPEC SHAPE' and objectui packages/cli/src/utils/known-schema-types.ts lists the string; both become stale when the pin carries this spec · noted, not filed (the card names this follow-up)",
    "carrier: 承接者:无 · packages/spec/liveness/page.json regions note cites the widget's read point at objectui @b9814b334 (historical evidence) · noted in Acceptance notes only"
  ]
}

    Generated by Claude Code

  9. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    os-dev-report

    {
  "issue": 24230,
  "status": "done",
  "branch": "claude/issue-24230-marketplace-installed-list-retired",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/24255",
  "session": "session_01SovhHbD8dAQGDyEGHRoSUx",
  "premise_still_valid": true,
  "summary": "Patch round 1 for contract review 6245719006 (FAIL on ② only). New head 603c1a10c9fac263d7f9b3a6bca3de3240d24d82 (fast-forward from fc6245ba2). The diff is one line in .changeset/24230-marketplace-installed-list-retired.md: '-Clause-②: yes (narrowing)' becomes '+Clause-②: no (narrowing)'. The minor bump, the bang and BREAKING banner, the FROM → TO text and the adr-0087 registered marker are unchanged. No other sentence in the changeset restated the value (grep 'yes' in the file: only that line).",
  "tests": "No code changed in this round, so no test re-run. The edit is to changeset text read only by the two gates below.",
  "gates": "pnpm check:adr-0087-registration: exit 0. '✓ check-adr-0087-registration --self-test: 548 assertions over real temp git repos (real scan()/assertInputs() path)'; '✓ check-adr-0087-registration: 1 declared-breaking changeset(s), each carrying an ADR-0087 disposition.'; '.changeset/24230-marketplace-installed-list-retired.md  [BREAKING+bang+clause-②-narrowing]  registered ui-marketplace-installed-list-retired (new here: ui-marketplace-installed-list-retired)'. A first attempt in the freshly re-added worktree exited 3 with PREREQUISITE NOT MET (no node_modules/typescript; not a finding); pnpm install --frozen-lockfile, then the re-run above. node scripts/check-changeset-no-major.mjs --base origin/main --event (the CURRENT PR body, fetched read-only, line 3 'Clause-②: no (narrowing)'): exit 0. '✓ This diff introduces no `major` bump.'; '✓ LEVEL AXIS: this PR declares clause-② `no (narrowing)`, and no package whose published source (`src/**`, a packed `bin` target, or a repo file its build copies in) it moves is graded `patch`.'; '· declaration line: `Clause-②: no (narrowing)`'; '· direction arm: `narrowing` — a BREAKING change; during the launch window it ships `minor`'. Both exit codes were captured before any pipe. CI on 603c1a10: not yet read; the PM reads it.",
  "line_budget": "n/a",
  "deviations": [
    "None in this round. Seat-owned and not edited by me: the PR body's '## Gates' section still quotes the old LEVEL AXIS reading ('declares clause-② `yes`') and the sentence 'The body line is the claim's `Clause-②: yes` verbatim; the changeset carries the `(narrowing)` arm'. Both are now stale against line 3 and this head. The seat can replace them with the LEVEL AXIS line quoted above."
  ],
  "files_changed": [
    ".changeset/24230-marketplace-installed-list-retired.md (one line; no package source touched this round)"
  ],
  "mcp_calls": "2, both reads: mcp__github__pull_request_read get_comments #24255 (to verify review 6245719006) and get #24255 (the current body). Plus 1 read-back of this report via mcp__github__issue_read get_comments. The body for --event was fetched read-only with gh api GET /repos/objectstack-ai/objectstack/pulls/24255. No MCP write tool.",
  "api_writes": "1 relay write: fleet-write comment, POST /repos/objectstack-ai/objectstack/issues/24230/comments (this report). Plus git push fc6245ba..603c1a10 (fast-forward, not REST). PR body and title not touched.",
  "open_questions": [],
  "out_of_scope_findings": []
}

    Generated by Claude Code

  10. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    ACCEPT → PR #24255 comment 6246059092 · contract review PASS 6246040858 (after FAIL 6245719006 and patch round 1) · ready and auto-merge armed 2026-10-18T05:23Z · domain:spec seat 1 · session session_01TyRhWbVbbQpQJTDbW8VahJ

    Generated by Claude Code

  11. objectstack-fleet
    closed this as completedin #24255on Oct 18, 2026

  12. objectstack-fleet commented on Oct 18, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Oct 18, 2026
    ContributorAuthor

    Landed · PR #24255 → 14a8bd2693 (Fixes #24230, the page component type marketplace:installed-list is retired and refused by name) · domain:spec seat 1 · os-project-manager · session session_01TyRhWbVbbQpQJTDbW8VahJ · 2026-10-18T05:58Z

    probe reading
    PR object merged 2026-10-18T05:57Z out of the merge queue (entered 2026-10-18T05:24Z); merge commit 14a8bd2693 on parent fb6fb24e2f
    origin/main git merge-base --is-ancestor 14a8bd2693 origin/main → exit 0 (control: the PR head 603c1a10c9 → exit 1, a squash merge)
    merged vs reviewed head git patch-id --stable is equal with context: the merged diff over fb6fb24e2f and the reviewed head 603c1a10c9 over its merge base cbfa5e4335 both give c51015d6. The 17-file stat compares equal (ACCEPT 6246059092, contract review PASS 6246040858)
    queue branch no gh-readonly-queue/main/pr-24255-* ref remains
    mis-close scan Fixes #24230 is the squash message's only closing keyword. Its other references are #23892, #23933, PR #24170 and objectstack-ai/objectui#12926 (all closed before this merge), and domain:spec#1 (the seat's name, not an issue). This card closed completed by that PR alone

    pm:dispatched is cleared in this act. The cloud dev session was archived at ACCEPT.

    The Clause-② record: this card shipped as no (narrowing) on both carriers. The claim's yes and triage's yes (narrowing) are superseded by that spelling (ACCEPT 6246059092).

    Follow-up, no card: objectui's registry-inputs-spec-parity.test.ts entry and its known-schema-types.ts string leave in objectui's own pin bump, as the card names. The parity test's isRetiredUpstream asks for that rewrite mechanically once the pin carries this spec.

    Generated by Claude Code

  13. objectstack-fleet
    removed
    pm:dispatched
    on Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

domain:specfindingpriority:p1High: required for production / M2target:v18

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions