Update Eigen to version 5.0.1 and streamline CMake configuration - #23
Merged
Merged
Conversation
- Use FetchContent_MakeAvailable instead of deprecated FetchContent_Populate - Add EXCLUDE_FROM_ALL to prevent Eigen headers from being installed into wheel - Disable Eigen doc/test builds
The #define in hypergraph.h is insufficient because nanobind/Eigen headers included before hypergraph.h already pull in <cmath> without the define. Adding it as a compile definition ensures it is set before any header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Eigen library to version 5.0.1 and simplify the CMake configuration for improved build efficiency.