fix(arborist): validate linked store deps against the store package - #9983
Open
manzoorwanijk wants to merge 3 commits into
Open
manzoorwanijk wants to merge 3 commits into
manzoorwanijk wants to merge 3 commits into
Conversation
manzoorwanijk
marked this pull request as ready for review
September 15, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
install-strategy=linked,npm lsreported dependencies with dist-tag, remote tarball, git orinstall-linksdirectory specs asinvalid, exiting withELSPROBLEMS.The edge target is a
Linkwhoseresolvedis alwaysfile:, so the source checks in dep-valid.js could never pass.Those checks now use the
.storepackage theLinkpoints to, while git ref lookups and plain directory links keep using theLink.When the hidden lockfile is not used, store packages also had no
resolvedbecausepackage-lock.jsonhas no entry at their.storelocation.Shrinkwrap.addnow falls back to the lockfile entry with the same name and version, and skips it when entries disagree onresolvedorintegrity.References
Fixes #9976