Fix period trends and add market source selection - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 30-day chart could rise while its badge said Downtrend because the badge always analyzed a separate 24-hour series. The badge and swing overlays now analyze the selected period's closed candles; incomplete, gapped, invalid, or stale data suppresses analysis. Live spot and the unfinished candle remain visible.
Add a Settings selector for Auto, Kraken, Binance, and Coinbase, applying to both prices and candles. Auto preserves Kraken → Coinbase fallback; explicit choices stay on the selected exchange and show candle-fetch failures. Source changes clear caches and discard in-flight results from the previous configuration. Binance uses clearly labeled USDT pairs; other exchanges use USD.
Normalize intervals across providers (15m for 1d, 1h for 7d, 4h for 14/30d), paginate Coinbase hourly history and aggregate complete UTC buckets, and preserve elapsed time when chart data has gaps.
Validation: 15 JavaScript regression checks across all four periods; Go provider-routing, pagination, OHLC aggregation, persistence, and configuration-change checks;
go test -race ./...,go vet ./..., and build passed. JavaScript checks also run in CI.