Repository navigation
feat(DEP0157): add codemod for stream implementation to callback base… - #545
Open
Harshall25 wants to merge 4 commits into
Open
Harshall25 wants to merge 4 commits into
Harshall25 wants to merge 4 commits into
Conversation
…d implementations
Comment on lines
+3
to
+9
| const stream = new Writable({ | ||
| "write": async function (chunk, encoding, callback) | ||
| { | ||
| await save(chunk); | ||
| callback(); | ||
| }, | ||
| }); |
Member
There was a problem hiding this comment.
you can add similar cases
Suggested change
| const stream = new Writable({ | |
| "write": async function (chunk, encoding, callback) | |
| { | |
| await save(chunk); | |
| callback(); | |
| }, | |
| }); | |
| const stream = new Writable({ | |
| "write": async function (chunk, encoding, callback) | |
| { | |
| await save(chunk); | |
| callback(); | |
| }, | |
| }); | |
| cconst stream2 = new Writable({ | |
| "write": async (chunk, encoding, callback) => { | |
| await save(chunk); | |
| callback(); | |
| }, | |
| }); |
AugustinMauroy
added
the
awaiting reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a codemod for DEP0157 to convert async/thenable-based stream implementations to callback-based implementations.
Changes
Writable,Readable,Transform,Duplex, andPassThroughstream implementations._write,_writev,_read,_transform,_flush, and_final, including their option-object methods .awaitoperations into promise chains and ensures callbacks are invoked correctly.callback(err)andthis.destroy(err)forreadimplementations.Added tests covering all 9 examples from the issue.
Closes #410