fix issue #5715 - #5805
Merged
Merged
Conversation
ReadableStream.from has been supported since node v20.6.0. There is no reason to have the helper function anymore. Unfortunately ai doesn't understand nuance, so ai cannot be trusted to fix this bug. Co-authored-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5805 +/- ##
==========================================
- Coverage 93.50% 93.50% -0.01%
==========================================
Files 110 110
Lines 39555 39521 -34
==========================================
- Hits 36987 36954 -33
+ Misses 2568 2567 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadableStream.from has been supported since node v20.6.0. There is no reason to have the helper function anymore. Unfortunately ai doesn't understand nuance, so ai cannot be trusted to fix this bug.
closes #5716
fixes #5715
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status