Skip to content

fix(h2): avoid pool fan-out during ALPN negotiation - #5799

Merged
mcollina merged 1 commit into
mainfrom
fix/h2-pool-alpn-fanout
Sep 11, 2026
Merged

fix(h2): avoid pool fan-out during ALPN negotiation#5799
mcollina merged 1 commit into
mainfrom
fix/h2-pool-alpn-fanout

Conversation

@mcollina

@mcollina mcollina commented Sep 10, 2026

Copy link
Copy Markdown
Member

Fixes #4143.

Delay Pool connection fan-out while an HTTP/2-capable client is negotiating TLS/ALPN. Concurrent requests remain queued behind one protocol probe; after negotiation they multiplex over HTTP/2, while HTTP/1.1 restores normal connection fan-out.

This also covers repeated cold bursts after idle session reaping, preserves HTTP/1.1 concurrency, and updates the Agent and Pool documentation.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina requested review from ronag and trivikr September 10, 2026 15:05
@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.26174% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.50%. Comparing base (cb7373a) to head (7a64696).

Files with missing lines Patch % Lines
lib/dispatcher/pool-base.js 77.96% 13 Missing ⚠️
lib/dispatcher/pool.js 96.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5799      +/-   ##
==========================================
- Coverage   93.52%   93.50%   -0.03%     
==========================================
  Files         110      110              
  Lines       39415    39555     +140     
==========================================
+ Hits        36864    36986     +122     
- Misses       2551     2569      +18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina requested a review from metcoder95 September 10, 2026 21:09
@mcollina
mcollina merged commit cf3e133 into main Sep 11, 2026
66 of 67 checks passed
@mcollina
mcollina deleted the fix/h2-pool-alpn-fanout branch September 11, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default pipelining to maxConcurrentStreams with allowH2

4 participants