quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED - #65442
Open
trivenay wants to merge 1 commit into
Open
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED#65442trivenay wants to merge 1 commit into
trivenay wants to merge 1 commit into
Conversation
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: nodejs#65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65442 +/- ##
==========================================
- Coverage 91.85% 90.10% -1.75%
==========================================
Files 400 752 +352
Lines 179110 252339 +73229
Branches 27351 47454 +20103
==========================================
+ Hits 164522 227382 +62860
- Misses 14258 16254 +1996
- Partials 330 8703 +8373
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Aug 20, 2026
Collaborator
trivikr
added
the
quic
trivikr
approved these changes
Aug 20, 2026
trivikr
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incoming HTTP/3 request stream is rejected without any application processing (the session has no stream consumer), it is now reset with
H3_REQUEST_REJECTEDso the peer learns the request was not processed, per RFC 9114 §4.1.1. The code is surfaced per-application like the existing no-error/internal-error codes, so non-HTTP/3 applications are unchanged.Fixes: #65441