perf_hooks: add statistical hypothesis testing to histogram - #65416
Open
jasnell wants to merge 2 commits into
Open
perf_hooks: add statistical hypothesis testing to histogram#65416jasnell wants to merge 2 commits into
jasnell wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
force-pushed
the
jasnell/more-histogram-fun
branch
from
August 20, 2026 13:24
f866877 to
bc4d71e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65416 +/- ##
========================================
Coverage 90.11% 90.11%
========================================
Files 752 752
Lines 252208 252898 +690
Branches 47447 47559 +112
========================================
+ Hits 227274 227911 +637
- Misses 16219 16261 +42
- Partials 8715 8726 +11
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/more-histogram-fun
branch
from
August 20, 2026 19:19
bc4d71e to
54c4c56
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
/cc @nodejs/performance |
jasnell
added
the
author ready
legendecas
approved these changes
Aug 20, 2026
Welch's t-test, Mann-Whitney U test, Cohen's d, and Cliff's delta, and and handful of others These methods enable in-process benchmark comparison and regression detection without external dependencies. No new dependencies. Tests and docs created by the AI agent. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Add an --analyze flag that performs statistical analysis directly
after benchmarks complete, eliminating the need for R and compare.R.
When --analyze is specified, compare.js collects the rate data during
the run and prints a statistical summary table instead of CSV output.
The table matches the format of compare.R: improvement percentage,
significance stars (* p<0.05, ** p<0.01, *** p<0.001), and confidence
intervals at three risk levels.
Also adds a --max-regression N option that causes the compare.js to
exit with 1 (error) when the `--new` is N% slower. Useful for CI
use to detect regressions.
Uses the histogram API's welchTest() and cohensD() methods introduced
in the previous commit. Benchmark rates are scaled to integers for
HdrHistogram recording; the --scale option (default 1000) controls
the multiplier for precision.
Usage:
node benchmark/compare.js --old ./node-old --new ./node-new \
--analyze url
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
jasnell
force-pushed
the
jasnell/more-histogram-fun
branch
from
August 20, 2026 20:35
54c4c56 to
0793579
Compare
Collaborator
jasnell
added
the
commit-queue-rebase
legendecas
approved these changes
Aug 20, 2026
jasnell
added
the
notable-change
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Member
Author
|
Notes for the notable change: This PR expands the analytical capabilities of |
jasnell
added
the
semver-minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue expanding the capabilities of the
HistogramAPI... and use it to enable a dependency-freebenchmark/compare.jsoption... i.e. no longer requiring R-script to show benchmark analysis... just runbenchmark/compare.jswith the--analyzeoption.The added algorithms cover analysis calculations that would be fairly common in perf analysis (latency, burn rates, detecting regressions, etc). Prior to this, really the only way to get these were to use aging outside dependencies (5+ years old) or R-script.
Just scratching an old itch I've been wanting since I added
Histogramback in v11. I've been doing a bunch of benchmarking lately with the QUIC and DTLS impls and just got tired of having to use outside deps for this stuff./cc @mcollina