src: constrain COW forwarding constructors - #64861
Open
Archkon wants to merge 1 commit into
Open
Conversation
Exclude the wrapper type from the forwarding constructors so that non-const lvalue copies select the copy constructor. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64861 +/- ##
==========================================
+ Coverage 90.16% 90.17% +0.01%
==========================================
Files 746 746
Lines 242760 242768 +8
Branches 45765 45759 -6
==========================================
+ Hits 218875 218907 +32
+ Misses 15375 15347 -28
- Partials 8510 8514 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude the wrapper type from the forwarding constructors so that non-const lvalue copies select the copy constructor.