embedder: return empty pointer without builtin snapshot - #64845
Open
Archkon wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
Avoid creating an EmbedderSnapshotData wrapper with null implementation when Node.js is built without a builtin snapshot. This ensures callers can reliably detect the unavailable snapshot through the public API. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64845 +/- ##
==========================================
+ Coverage 90.14% 90.20% +0.05%
==========================================
Files 746 746
Lines 242771 242931 +160
Branches 45741 45803 +62
==========================================
+ Hits 218850 219134 +284
+ Misses 15426 15331 -95
+ Partials 8495 8466 -29
🚀 New features to boost your workflow:
|
saitejabandaru-in
left a comment
saitejabandaru-in
left a comment
There was a problem hiding this comment.
LGTM! Returning an empty Pointer explicitly when snapshot_data is nullptr safely avoids wrapping a null implementation, aligning with the expected behavior of EmbedderSnapshotData::BuiltinSnapshotData when the snapshot is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid creating an EmbedderSnapshotData wrapper with null implementation when Node.js is built without a builtin snapshot. This ensures callers can reliably detect the unavailable snapshot through the public API.