test_runner: add support for --test-coverage-include-all - #64830
Closed
avivkeller wants to merge 2 commits into
Closed
test_runner: add support for --test-coverage-include-all#64830avivkeller wants to merge 2 commits into
avivkeller wants to merge 2 commits into
Conversation
Signed-off-by: avivkeller <me@aviv.sh>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
avivkeller
commented
Jul 29, 2026
avivkeller
commented
Jul 29, 2026
Co-authored-by: Aviv Keller <me@aviv.sh>
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64830 +/- ##
==========================================
- Coverage 90.15% 90.12% -0.04%
==========================================
Files 744 746 +2
Lines 242542 242819 +277
Branches 45690 45741 +51
==========================================
+ Hits 218672 218836 +164
- Misses 15362 15463 +101
- Partials 8508 8520 +12
π New features to boost your workflow:
|
MoLow
approved these changes
Jul 30, 2026
atlowChemi
approved these changes
Jul 30, 2026
avivkeller
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
avivkeller
added
semver-minor
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64830 β Done loading data for nodejs/node/pull/64830 ----------------------------------- PR info ------------------------------------ Title test_runner: add support for --test-coverage-include-all (#64830) Author Aviv Keller <me@aviv.sh> (@avivkeller) Branch avivkeller:test-coverage-include-all -> nodejs:main Labels c++, semver-minor, lib / src, author ready, needs-ci Commits 2 - test_runner: add support for --test-coverage-include-all - Apply suggestions from code review Committers 2 - avivkeller <me@aviv.sh> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/64830 Fixes: https://github.com/nodejs/node/issues/58887 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64830 Fixes: https://github.com/nodejs/node/issues/58887 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> -------------------------------------------------------------------------------- βΉ This PR was created on Wed, 29 Jul 2026 21:19:50 GMT β Approvals: 2 β - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/64830#pullrequestreview-4815157653 β - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/64830#pullrequestreview-4818548199 β GitHub CI is still running βΉ Last Full PR CI on 2026-07-30T15:53:22Z: https://ci.nodejs.org/job/node-test-pull-request/75310/ - Querying data for job/node-test-pull-request/75310/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/30667054569 |
Member
Author
|
Landed in b7d29fe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add s a CLI option to include source files that were never loaded by the test run in the coverage
report, where they are reported as having zero coverage. Candidate files are searched for in the current working directory, and are subject to the same
--test-coverage-includeand--test-coverage-excludefiltering as the rest of the report.Fixes: #58887
As discussed during today's @nodejs/test_runner meeting with @ljharb and @JakobJingleheimer